Disable reload when in about:bookmarks

RESOLVED FIXED in Camino0.9

Status

RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: camino, Assigned: jaas)

Tracking

unspecified
Camino0.9
PowerPC
macOS

Details

Attachments

(1 attachment)

967 bytes, patch
sfraser_bugs
: review-
Details | Diff | Splinter Review
(Reporter)

Description

14 years ago
Disable the Reload toolbar item when you are showing the bookmarks manager
(about: bookmarks). Hitting the button doesn't do anything, but because the
progress bar does show activity people might think they need to reload in some
circomstances.
this is for history too. 
Target Milestone: --- → Camino0.9
(Assignee)

Comment 2

14 years ago
the toolbar item does appear to be disabled, but the reload menu item is not
disabled
(Assignee)

Comment 3

14 years ago
this is a bug, not an enhancement...
Severity: enhancement → normal
(Assignee)

Comment 4

14 years ago
Created attachment 178202 [details] [diff] [review]
fix v1.0

this disables the Reload menu item and a bunch of other stuff that shouldn't be
enabled when the bookmark/history manager is open...
Assignee: pinkerton → joshmoz
Status: NEW → ASSIGNED
Attachment #178202 - Flags: superreview?(pinkerton)
Attachment #178202 - Flags: review?(sfraser_bugs)

Comment 5

14 years ago
Comment on attachment 178202 [details] [diff] [review]
fix v1.0

This stuff just shouldn't be wired to the MainController in the first place;
the menu items should be wired to FirstResponder, and then Cocoa will do the
enabling for us.
Attachment #178202 - Flags: review?(sfraser_bugs) → review-
(Assignee)

Updated

14 years ago
Attachment #178202 - Flags: superreview?(pinkerton)
shouldn't that be addressed as a separate bug?

Comment 7

14 years ago
Yeah, it's bigger than I thought to do it right. I think it will have to be done
method-by-method to get it right.
(Assignee)

Comment 8

14 years ago
landed fix v1.0 for 0.9, leaving the "correct" fix for later cleanup
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.