284896 - QA contact never receives mail when removed from a bug

Status: RESOLVED FIXED

(Bugzilla :: Email Notifications, defect)

Description

[Olav Vitters]

When reassigning a bug, the QA contact never receives an email. This is NOT due
to some email setting.

In post_bug.cgi it sets {'mailrecipients'}->{'qa'}.
In process_bug.cgi it sets 'qa'. The mailrecipients is passed on to SendBugMail
in the bug/process/bugmail.html.tmpl. SendBugMail refers to the function Send
(in Bugzilla/BugMail.pm).

The Send function checks for 'qacontact', not 'qa'. It therefore sets
$force{'QAcontact'} to () instead of the original QA contact.

Patch modifies post_bug.cgi and process_bug.cgi to use 'qacontact'. I decided to
change those files instead of Bugzilla/BugMail.pm to not change how the Send
function works.

Note: From a quick look this bug is also in Bugzilla 2.18.

Comment 1

[Olav Vitters]

Attachment: Patch v1

Comment 2

[Marc Schumann [:Wurblzap]]

Comment on attachment 176367 [details] [diff] [review]
Patch v1

Good catch.

Nit: next time, please keep the line length below 80 chars :)

Comment 3

[Marc Schumann [:Wurblzap]]

The patch doesn't apply to the 2.18 branch. It seems like an easy backport to me
-- if you can do it, can you please put up a branch patch and put r+ on it?

Comment 4

[Olav Vitters]

Attachment: Patch for Bugzilla 2.18 branch

I added the wrapping, but however I wrap it;
DBID_to_name($::FORM{'qa_contact'}) wholly on a new line, or only
$::FORM{'qa_contact'}, it looks strange (maybe that's just me).

Comment 5

[Shane H. W. Travis]

Attachment: fixed patch for 2.18

Your patch doesn't apply against 2.18 at all; this is probably because it
wasn't taken against the 2.18 branch. (If it were, the revision numbers would
be x.x.x.x instead of just the x.x of the trunk/tip.)

Here is the patch I committed, properly diffed against a 2.18 installation.

Comment 6

[Shane H. W. Travis]

2.18:
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.88.2.6; previous revision: 1.88.2.5
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.205.2.15; previous revision: 1.205.2.14
done

Tip:
Checking in post_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/post_bug.cgi,v  <--  post_bug.cgi
new revision: 1.106; previous revision: 1.105
done
Checking in process_bug.cgi;
/cvsroot/mozilla/webtools/bugzilla/process_bug.cgi,v  <--  process_bug.cgi
new revision: 1.241; previous revision: 1.240
done