284943 - Reduce debug noise from static component loader

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Darin Fisher]

The static component loader outputs a 3 lines of text for every module.  Most
developers won't care about that output.  We should convert the code to using
NSPR logging instead.

Comment 1

[Darin Fisher]

Attachment: v1 patch

Comment 2

[Benjamin Smedberg]

Comment on attachment 176398 [details] [diff] [review]
v1 patch

>Index: nsStaticComponentLoader.cpp

>+#ifdef PR_LOGGING
>+static PRLogModuleInfo *sLog = PR_NewLogModule("StaticComponentLoader");
>+#endif

Are you allowed to do that? Don't we still have byzantine toolchains around
that don't run static initalizers?

Comment 3

[Darin Fisher]

http://lxr.mozilla.org/seamonkey/source/docshell/base/nsWebShell.cpp#128
http://lxr.mozilla.org/seamonkey/source/modules/libutil/public/stopwatch.h#42
http://lxr.mozilla.org/seamonkey/source/netwerk/base/src/nsProtocolProxyService.cpp#62
http://lxr.mozilla.org/seamonkey/source/netwerk/cookie/src/nsCookieService.cpp#197
http://lxr.mozilla.org/seamonkey/source/xpcom/threads/nsTimerImpl.h#57
http://lxr.mozilla.org/seamonkey/source/gfx/src/gtk/nsDeviceContextSpecG.cpp#75
...

and the list goes on.  we have good convention for allocating log modules this
way, so i think it should be ok here.

Comment 4

[Darin Fisher]

fixed-on-trunk

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Looks like this broke the balsa tinderbox on SeaMonkey-Ports.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

never mind; tree had local changes