Closed Bug 284959 Opened 20 years ago Closed 20 years ago

warning at nsPrefService.cpp:747 when defaults/pref directory not found

Categories

(Core :: Preferences: Backend, defect)

defect
Not set
minor

Tracking

()

RESOLVED FIXED
mozilla1.8beta2

People

(Reporter: darin.moz, Assigned: darin.moz)

Details

Attachments

(1 file)

warning at nsPrefService.cpp:747 when defaults/pref directory not found

The pref_LoadPrefsInDir function returns an error when the given directory does
not exist.  That causes nsPrefService to output a NS_WARNING.  In the case of
xulrunner, which doesn't have a defaults/pref directory (since there are no
xulrunner specific prefs), this results in the warning at startup:

WARNING: Error parsing application default preferences., file
c:/builds/moz-trunk/mozilla/
modules/libpref/src/nsPrefService.cpp, line 747

That warning seems concerning, but it really isn't anything to be concerned
with.  I think we should suppress this warning when the directory simply doesn't
exist.

Patch coming up.
Attached patch v1 patchSplinter Review
Simple patch.  Fix pref_LoadPrefsInDir to not return an error in this case.
Attachment #176419 - Flags: review?(benjamin)
Status: NEW → ASSIGNED
Target Milestone: --- → mozilla1.8beta2
Attachment #176419 - Flags: review?(benjamin) → review+
fixed-on-trunk
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: