284975 - Any code after Throw*Error is a dead code.

Status: RESOLVED FIXED

Description

[Tomas Kopal]

There is couple of places where we call exit after Throw*Error call. As
Throw*Error calls do never return, the exit is just confusing and should be
removed. See bug 277782 for more details.
Patch follows.

Comment 1

[Tomas Kopal]

Created attachment 176440 [details] [diff] [review]
V1

Comment 2

[Frédéric Buclin]

Comment on attachment 176440 [details] [diff] [review]
V1

r=LpSolit

Comment 3

[Frédéric Buclin]

Comment on attachment 176440 [details] [diff] [review]
V1

>--- editcomponents.cgi	5 Mar 2005 00:18:48 -0000	1.49
>+++ editcomponents.cgi	6 Mar 2005 06:58:22 -0000
>@@ -66,14 +66,12 @@
> 
>     # do we have a product?
>     unless ($prod) {
>-        ThrowUserError('product_not_specified');
>-        exit;
>+        ThrowUserError('product_not_specified');    
>     }


Nit: there are trailing whitespaces at the end of
ThrowUserError('product_not_specified');. This should be removed before
checking this patch in.

Comment 4

[Max Kanat-Alexander]

Checking in createaccount.cgi;
/cvsroot/mozilla/webtools/bugzilla/createaccount.cgi,v  <--  createaccount.cgi
new revision: 1.37; previous revision: 1.36
done
Checking in editclassifications.cgi;
/cvsroot/mozilla/webtools/bugzilla/editclassifications.cgi,v  <-- 
editclassifications.cgi
new revision: 1.7; previous revision: 1.6
done
Checking in editcomponents.cgi;
/cvsroot/mozilla/webtools/bugzilla/editcomponents.cgi,v  <--  editcomponents.cgi
new revision: 1.50; previous revision: 1.49
done
Checking in editkeywords.cgi;
/cvsroot/mozilla/webtools/bugzilla/editkeywords.cgi,v  <--  editkeywords.cgi
new revision: 1.24; previous revision: 1.23
done
Checking in editmilestones.cgi;
/cvsroot/mozilla/webtools/bugzilla/editmilestones.cgi,v  <--  editmilestones.cgi
new revision: 1.33; previous revision: 1.32
done
Checking in editproducts.cgi;
/cvsroot/mozilla/webtools/bugzilla/editproducts.cgi,v  <--  editproducts.cgi
new revision: 1.71; previous revision: 1.70
done
Checking in editversions.cgi;
/cvsroot/mozilla/webtools/bugzilla/editversions.cgi,v  <--  editversions.cgi
new revision: 1.32; previous revision: 1.31
done