Closed Bug 285006 Opened 20 years ago Closed 20 years ago

outer table frame should account for margin during printing

Categories

(Core :: Layout: Tables, defect)

Product:
Core
Component:
Layout: Tables
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED

People

(Reporter: bernd_mozilla, Assigned: bernd_mozilla)

Details

Attachments

(1 file)

patch
1.55 KB, patch
roc
: review+
roc
: superreview+
Details | Diff | Splinter Review 
this is a followup from bug 274516 I attached there a patch which should go in
Attached patch patch — — Splinter Review 

        Attachment #176486 -
        Flags: superreview?(roc)

        Attachment #176486 -
        Flags: review?(roc)

    
    

    
  
Comment on attachment 176486 [details] [diff] [review]
patch

+    if (NS_UNCONSTRAINEDSIZE != margin.top)

How can this be NS_UNCONSTRAINEDSIZE?

    
    

    
  
its just my paranoia of unconstrainedsize  arithmetic. 

    
    

    
  
Comment on attachment 176486 [details] [diff] [review]
patch

ok, just replace it with an assertion != UNCONSTRAINEDSIZE then.

        Attachment #176486 -
        Flags: superreview?(roc)

        Attachment #176486 -
        Flags: superreview+

        Attachment #176486 -
        Flags: review?(roc)

        Attachment #176486 -
        Flags: review+

    
  
Assignee: nobody → bernd_mozilla

    
    

    
  
the patch fixes the warning at
http://lxr.mozilla.org/seamonkey/source/layout/tables/nsTableRowGroupFrame.cpp#1044
in https://bugzilla.mozilla.org/attachment.cgi?id=168707
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: