285009 - list of events (unifinder) doesn't show on load

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[Michiel van Leeuwen (email: mvl+moz@)]

The list of events on top of the screen (unifinder) doesn't show anything when
the window opens. It only shows events when the dropdown is changed (to all-day
or something).

Comment 1

[Jeremy Teo]

Attachment: One liner fix to make unifinder display search results upon first load

One liner fix to force the unifinder to refresh upon first load of Sunbird.

Comments appreciated: Is the fix really so simple?

Comment 2

[Michiel van Leeuwen (email: mvl+moz@)]

While this might work, i'm not sure if it is the right thing.
In any case, an observer should be added to update the list on changes to the
calendar, like added or deleted events. And on loading the calendar.
But this patch might still be needed, i didn't check that yet.

Comment 3

[Jeremy Teo]

Attachment: Refreshs unifinder on first load, and adds an observer for it to monitor addItem, deleteItem etc

The semantics of onLoad() for any observer seem to be broken/fuzzy. As i
understand it from mvl, onLoad() is mostly an old holdover back when everything
was in .ics files.

Hence I've decided to manually force a refresh the first time the unifinder is
loaded, and attach an observer for it to make it refresh when events are added
etc etc.

Comments appreciated.

Comment 4

[Jeremy Teo]

Attachment: Better and more complete fix

unifinderObserver should be declared as a var, not as a function and then
tacking on stuff onto its prototype.

Also I forgot to removeObserver() when the calendar is unloaded.

As mentioned earlier, onLoad() doesn't work properly for observers. So we
manually refresh upon first load.

addItems, modifyItems, are all caught by the unifinder now.

Comment 5

[Stuart Parmenter]

Comment on attachment 177005 [details] [diff] [review]
Better and more complete fix

It dawned on me that we need additional calendar changed notifications so that
you can removeObserver on this calendar and addObserver on the new one.  I need
to think through that a little more... Probably add something to
calICalendarManager.  We also need that in the calendar window, so this is OK
for now.

Comment 6

[Michiel van Leeuwen (email: mvl+moz@)]

checked in the patch

Comment 7

[Reed Loden [:reed]]

The bugspam monkeys have been set free and are feeding on Calendar :: Sunbird Only. Be afraid for your sanity!