285048 - nsImageWin::ConvertDDBtoDIB uses wrong color depth

Status: RESOLVED FIXED

(Core Graveyard :: GFX: Win32, defect, P2)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

ConvertDDBtoDIB passes the color depth of the DDB to BuildDIB. That's wrong -
callers of nsImageWin::GetBits expect the color depth to be whatever nsImageWin
currently uses (24bpp, usually). So, this function should pass mNumBytesPixel*8
to BuildDIB.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Ere Maijala (slow)]

Comment on attachment 176515 [details] [diff] [review]
patch

If mNumBytesPixel is bytes as the name implies, you shouldn't multiply it. If
it's actually bits, please fix the variable name.

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 176515 [details] [diff] [review]
patch

mNumBytesPixel is what it says; but I still need to multiply it, since BuildDIB
expects bits per pixel, not bytes...

Comment 4

[Ere Maijala (slow)]

Comment on attachment 176515 [details] [diff] [review]
patch

Sorry, you're right :/

Note to self: don't do reviews early in the morning.

Comment 5

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in gfx/src/windows/nsImageWin.cpp;
/cvsroot/mozilla/gfx/src/windows/nsImageWin.cpp,v  <--  nsImageWin.cpp
new revision: 3.142; previous revision: 3.141
done