285112 - Move ValidateBugID out of CGI.pl

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, enhancement)

Description

[Frédéric Buclin]

This function should go into Bug.pm.

Comment 1

[Frédéric Buclin]

Attachment: patch, v1

Comment 2

[Frédéric Buclin]

Comment on attachment 188894 [details] [diff] [review]
patch, v1

I want to be sure I didn't break ValidateBugID(). Requesting a second review.

Comment 3

[Joel Peshkin]

Comment on attachment 188894 [details] [diff] [review]
patch, v1

r=joel
await 2xr

Comment 4

[Teemu Mannermaa (:wicked)]

Comment on attachment 188894 [details] [diff] [review]
patch, v1

Tested to be seemingly working as advertised.

Verified correct output of ValidateBugID when given input of 1) correct/invalid
alias 2) existing/non-existing ID and 3) bugs that the user has no access to
(both anonymous and logged in user as well as dependent change). Also briefly
tested all affected .cgi files.

Note that change for show_activity.cgi was already committed in bug 300501 so
that's no longer necessary.

Comment 5

[Frédéric Buclin]

Checking in CGI.pl;
/cvsroot/mozilla/webtools/bugzilla/CGI.pl,v  <--  CGI.pl
new revision: 1.246; previous revision: 1.245
done
Checking in showdependencygraph.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencygraph.cgi,v  <-- 
showdependencygraph.cgi
new revision: 1.39; previous revision: 1.38
done
Checking in showdependencytree.cgi;
/cvsroot/mozilla/webtools/bugzilla/showdependencytree.cgi,v  <-- 
showdependencytree.cgi
new revision: 1.33; previous revision: 1.32
done
Checking in Bugzilla/Bug.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/Bug.pm,v  <--  Bug.pm
new revision: 1.83; previous revision: 1.82
done