Closed Bug 285138 Opened 19 years ago Closed 19 years ago

Spellchecker doesn't skip quoted text in plain text editor

Categories

(Thunderbird :: Message Compose Window, defect)

x86
Windows 2000
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird1.1

People

(Reporter: mik77, Assigned: mscott)

Details

Attachments

(2 files)

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; de-AT; rv:1.8b) Gecko/20050217 Mnenhy/0.7.1
Build Identifier: Thunderbird version 1.0+ (20050306)

In the newest nightlys the spellchecker doesn't skip quoted text. But only in
the plain text editor. The HTML editor skips the quoted text.

After some testing I found out that this appears to be caused by the patch for
bug 278312.

Reproducible: Always

Steps to Reproduce:
1. reply to a Mail with the plain text editor
2. (add some own text)
3. start the spellchecker

Actual Results:  
The quoted text is checked by the spellchecker.

Expected Results:  
The spellchecker should skip quoted text.
Thunderbird 1.0 did skip the quoted text.
Confirmed with TB 1.0+0303, Win2K.
Status: UNCONFIRMED → NEW
Ever confirmed: true
This bug makes the spellchecker almost useless, because after some time you just
click on "ignore".
Does anybody know how this was broken and how difficult it is to fix it?
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird1.1
Attached patch the fixSplinter Review
This broke when I landed inline spell check because we were stomping over
_retval when we checked to see if the content node was a moz-signature.
Attachment #179336 - Flags: superreview?(bienvenu)
Attachment #179336 - Flags: review?(daniel)
Attachment #179336 - Flags: superreview?(bienvenu) → superreview+
Comment on attachment 179336 [details] [diff] [review]
the fix

>         nsAutoString className;
>-        if (NS_SUCCEEDED(content->GetAttr(kNameSpaceID_None, mClassAtom, className))) {
>+        if (!*_retval && NS_SUCCEEDED(content->GetAttr(kNameSpaceID_None, mClassAtom, className))) {
>           *_retval = className.EqualsLiteral("moz-signature");
>         }


Make it

  if (!*_retval) {
    nsAutoString className;
    if (NS_SUCCEEDED(content->GetAttr(kNameSpaceID_None, mClassAtom,
className))) {
      *_retval = className.EqualsLiteral("moz-signature");
    }
  }

so you don't create the string if you don't need it and you have my
r=daniel@glazman.org, no need to ask again.
Attachment #179753 - Flags: superreview+
Attachment #179753 - Flags: review+
Comment on attachment 179336 [details] [diff] [review]
the fix

moving forward daniel's r= after I made the suggested change.
Attachment #179336 - Flags: review?(daniel) → review+
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: