285142 - network.image.imageBehavior = 2 blocks images, against settings in preferences

Status: RESOLVED WORKSFORME

(Core :: Graphics: Image Blocking, defect)

Description

[Hermann Schwab]

network.image.imageBehavior = 2 was blocking display of images in an important
profile. I don´t know how this got set, maybe a nightly, maybe using a very old
version of mozilla, unlikely by installing an extension. 
I´ve tried all image blocking settings in preferences, and could see images on
some websites only if I allowed the sites in image manager, the moment I removed
the site images were disallowed.

There is no GUI for setting this, there were no placeholders seen, so it is very
confusing. Is this a preference set by Mozilla 1.5, replaced by another one
today, but still respected?
So somebody updating from Mozilla 1.5 with images blocked would have no chance
to reset the image blocking in a current Mozilla.

Steps to repeat:
1. about:config
2. set/create network.image.imageBehavior integer 2
3. load a page, and miss images and placeholders
4. try to unblock images without using Image Manager

This preference should be documented, or reset by preferences.

advanced.always_load_images default boolean true
browser.display.show_image_placeholders  default boolean true
network.image.warnAboutImages default boolean false

Bug 220927 Image placeholder displayed inconsistently when images are blocked
(network.image.imageBehavior=2)

Comment 1

[Michiel van Leeuwen (email: mvl+moz@)]

network.image.imageBehavior is obsolete. It should be automaticly reset, after
being imported to permissions.default.image. There is code that does this. But
only when starting mozilla. So the steps to reproduce are expected (as long as
extenions/cookie/nsImgManager lives)
Is everything ok after restarting mozilla?

Comment 2

[Hermann Schwab]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b2) Gecko/20050307
Normally I use an own Profile for Mozilla 1.4.2, or others for other old
versions. Sometimes I´m confirming to fast so my normal profile is used.
Now I tried to use 1.4.2 with my normal profile to block images and then see how
1.8b will react. I´m using zips.

1. 
started Mozilla 1.4.2, and blocked images using Preferences. I checked with
about:config that this was done by setting network.image.imageBehavior = 2

2. 
unzipped current nightly, creating a new directory. Started, saw no loading of
images, about:config was showing
network.image.imageBehavior user set integer 2
permissions.default.image default integer 1

3. right-click & Reset network.image.imageBehavior
network.image.imageBehavior default integer 

Now images are loading. Doing a reload of the about:config tab
network.image.imageBehavior isn´t seen anymore.

Maybe the code to transfer network.image.imageBehavior to
permissions.default.image is executed only when permissions.default.image
doesn´t exist. It seems wrong however, that obsolete
network.image.imageBehaviour still blocks images without giving any notice, when
permissions.default.image allows it.

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Is this still a problem, now that the old image blocker is no longer part of the
build?

Comment 4

[Hermann Schwab]

(In reply to comment #3)
> Is this still a problem, now that the old image blocker is no longer part of the
> build?

can you tell me when it got checked out, so I can test against the t just
blocked third party images using Mozilla 1.4.2, resulting in a setting of
network.image.imageBehavior = 1.
Using a current trunk nightly, I didn´t notice image blocking, so I changed it
using about:config to value 2.
Still no image blocking seen.
I`ll use this setting for the next week, and will reopen the bug, if there will
be reason to do so.

Resolving wfm, as I don´t know which checkin was responsible.

network.image.imageBehavior = 2