Closed
Bug 285153
Opened 20 years ago
Closed 20 years ago
"New editusers.cgi broke group visibility" cleanliness re-do
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.20
People
(Reporter: Wurblzap, Assigned: Wurblzap)
References
Details
Attachments
(1 file)
|
5.33 KB,
patch
|
LpSolit
:
review+
|
Details | Diff | Splinter Review |
I agreed to re-do the bug 284155 patch in a hackiness-reduced way although I like the way it's being done there :)
|
Assignee | |
Comment 1•20 years ago
|
||
The biggest hunk of the diff is a move into an if-block.
Attachment #179837 -
Flags: review?
The 'hackiness' way was copied from other places in BZ, and is still being used for new patches (e.g. bug#286360). BZ should probably be consistent, shouldn't it? How about WONTFIXing this one? (Or, and I don't really mind either way, creating another bug to make BZ consistent?)
|
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
|
||
Comment 3•20 years ago
|
||
Comment on attachment 179837 [details] [diff] [review] Patch happy to see this '-1' trick going away. r=LpSolit
Attachment #179837 -
Flags: review? → review+
|
|
||
Updated•20 years ago
|
Flags: approval?
|
||
Updated•20 years ago
|
Flags: approval? → approval+
Target Milestone: --- → Bugzilla 2.20
|
|
||
Comment 4•20 years ago
|
||
Checking in editusers.cgi; /cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v <-- editusers.cgi new revision: 1.86; previous revision: 1.85 done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•