Closed Bug 285270 Opened 20 years ago Closed 10 years ago

RFE - Make "sound events" configurable per channel

Categories

(Other Applications :: ChatZilla, enhancement)

Product:
Other Applications
Component:
ChatZilla
Type:
enhancement
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: Jim_Razmus, Assigned: hunboy)

References

(Depends on 1 open bug)

Details

(Whiteboard: [cz-0.9.91])

Attachments

(1 file, 1 obsolete file)

patch v1.0.1
6.12 KB, patch
bugzilla-mozilla-20000923
: review+
Details | Diff | Splinter Review 
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050223 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050223 Firefox/1.0.1

I would like to be able to specify unique sound events per channel that override
the global settings were appropriate.  Specifically, I would like to enable
aggressive notification for every message in one specific channel, while leaving
other channels to adopt the "sound events" in the global settings.

Reproducible: Always
Status: UNCONFIRMED → NEW
Ever confirmed: true
OS: Windows XP → All
Hardware: PC → All
Depends on: 252848
QA Contact: samuel → chatzilla
Attached patch patch v1.0 (obsolete) — — Splinter Review 
Assignee: rginda → utasir
Status: NEW → ASSIGNED

    
    

    
  
Comment on attachment 8430761 [details] [diff] [review]
patch v1.0

I've replaced this feature from global to general at the preferences because of network/channel dependence. Hopefully I didnot mis anything.

Test was ok, so ready to r+-

r? at Silver

        Attachment #8430761 -
        Flags: review?(bugzilla-mozilla-20020327)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch v1.0.1
        — 
          — Splinter Review
      

    


  
Keep the global properties (enable,overlap) under the global tab, only network/channel dependent prefs go to general tab. (Same way as at popup)

        Attachment #8430761 -
        Attachment is obsolete: true

        Attachment #8430761 -
        Flags: review?(bugzilla-mozilla-20020327)

        Attachment #8432271 -
        Flags: review?(bugzilla-mozilla-20020327)

    
    

    
  
Comment on attachment 8432271 [details] [diff] [review]
patch v1.0.1

Review of attachment 8432271 [details] [diff] [review]:
-----------------------------------------------------------------

Looks good, apologies for the delay!

        Attachment #8432271 -
        Flags: review?(bugzilla-mozilla-20020327) → review+

    
    

    
  
http://hg.mozilla.org/chatzilla/rev/2b6d7d16d451
Status: ASSIGNED → RESOLVED
Closed: 10 years ago
Resolution: --- → FIXED
Whiteboard: [cz-0.9.91]

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: