285380 - Bugzilla::DB::Schema uses ThrowCodeError incorrectly

Status: RESOLVED FIXED

(Bugzilla :: Bugzilla-General, defect, P1)

Description

[Max Kanat-Alexander]

This is causing Tinderbox to burn, but the patch was so huge I don't want to
back it out right now.

It's a very simple fix, which I will attach.

Comment 1

[Max Kanat-Alexander]

This really should be "minor," but it's making Tinderbox burn.

Comment 2

[Max Kanat-Alexander]

Attachment: Change it to a "die"

I just changed it to a die -- this code is called mostly at the command-line
anyway.

Comment 3

[:glob ✱]

Comment on attachment 176815 [details] [diff] [review]
Change it to a "die"

r=glob

Comment 4

[Max Kanat-Alexander]

Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.2; previous revision: 1.1
done

Comment 5

[Max Kanat-Alexander]

There are more instances of ThrowCodeError. :-(

Comment 6

[Max Kanat-Alexander]

Attachment: Fix the rest of them

Comment 7

[Max Kanat-Alexander]

Checking in Bugzilla/DB/Schema.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Schema.pm,v  <--  Schema.pm
new revision: 1.3; previous revision: 1.2
done