28540 - [RFE] FTP: nsFTPListingConv creates incorrect date in http-index-format

Status: VERIFIED FIXED

(Core Graveyard :: Networking: FTP, enhancement, P3)

Description

[Jonas Utterstrom]

I have played around with "file" and "ftp" url directory listings. I noticed
that the ftp http-index-format was incorrectly formatted. 

The code in "nsFTPListingConv.cpp" uses a nsIDateFormat object which depends on
the locale settings (sv_SE in my case). 
http://lxr.mozilla.org/seamonkey/source/netwerk/streamconv/converters/nsFTPDirListingConv.cpp#877

This date should be formatted as a RFC822 date, which it is in the "file" url. 
http://lxr.mozilla.org/seamonkey/source/netwerk/base/src/nsDirectoryIndexStream.cpp#226
So I took the code from the file url and modified nsFTPListingConv. See the
patch I have attached to this bug.

Comment 1

[Jonas Utterstrom]

Attachment: nsFTPDirListingConv date fix

Comment 2

[Jonas Utterstrom]

I have verified that the patch works on Windows NT also. And as a bonus, the ftp
directory view in Mozilla no longer thinks that files are directories in Linux.
The directory view in Windows worked before my patch, but it didn't follow the
date specification for http-index-format
(http://www.area.com/~roeber/file_format.html)

Comment 3

[Daniel Bratell]

cc:ing Judson Valeski who wrote the original code.

Comment 4

[Andreas Otte]

*** Bug 28536 has been marked as a duplicate of this bug. ***

Comment 5

[Warren Harris]

=> jud

Comment 6

[Jonas Utterstrom]

How can it be that this bug is still not fixed? Patches have a tendency to grow
old, so it is better to apply the patch earlier than later. I will also retract
that this bug doesn't exist in NT, it also appears when I changed locale from US
to Swedish.

Comment 7

[Andreas Otte]

I talked (mailed) with Judson Valeski about this. He sees the problem but does
not like the solution or thinks it should be done in another way. As I
understood him he thinks the http-index-format should be changed instead. With
the great beta push all people concentrated on PDT+ bugs and this one was not
marked as such. 

I'm sure he will get back to this after the beta push.

Comment 8

[Jonas Utterstrom]

That's fine by me. But I see no point in making a format locale-dependent when
it never is displayed for the user. It makes parsing simpler and faster to use
the RFC822 format. And it removes a dependency to the i18n/l10n modules.

Comment 9

[Warren Harris]

Moving post beta bugs to M18 which is now the post-beta milestone.

Comment 10

[Gagan]

robert-- welcome to necko!

Comment 11

[Gagan]

Hi dougt, welcome to necko :)

Comment 12

[Doug Turner (:dougt)]

to bradley.

Comment 13

[Bradley Baetz (:bbaetz)]

This is fixed by my dirviewer rewrite, although according to bug 38014 it
doesn't work on windows. helpwanted in tracking that down.

Comment 14

[benc]

+makingtest:

I'm not very saavy about this issue, so if there are an specific examples 
someone can provide, or suggested testcases, that would be great. I'll work on 
reading as many relevant bugs as I can.

Comment 15

[benc]

Jonas: if this works the way you expect, can you mark your bug "VERIFIED"?

Comment 16

[benc]

VERIFIED, this bug is subsummed by 38014. If there is a problem w/ dates, file a
new bug.

Comment 17

[Brant Gurganus]

[RFE] is deprecated in favor of severity: enhancement.  They have the same meaning.