285405 - add ".pkcs12" as filter in file dialog

Status: RESOLVED WONTFIX

(Core Graveyard :: Security: UI, defect)

Description

[Henrik Gemal]

in:
http://lxr.mozilla.org/mozilla/source/security/manager/pki/resources/content/certManager.js#320
we have
*.p12; *.pfx
as filters for pkcs12 files

Some programs create files that ends in:

so please change:
"*.p12; *.pfx"
into:
"*.p12; *.pfx; *.pkcs12"
pkcs12

Comment 1

[Henrik Gemal]

Attachment: patch to add pkcs12 to filter

Comment 2

[Wan-Teh Chang]

Comment on attachment 176867 [details] [diff] [review]
patch to add pkcs12 to filter

Henrik,

This change is very straightforward.  Could
you tell me which programs use the .pkcs12
suffix?

I am not a Mozilla superreviewer, so I can't
give a sr+.

Comment 3

[Kai Engert (:KaiE:)]

This patch isn't really necessary, is it?
If you know you have a file with this extension, you can always change the file
browsing dialog to display all files, right?

Please answer Wan-Teh's question. Unless the program you used is a very popular
one, I'd say, the patch is not necessary.

Comment 4

[Henrik Gemal]

(In reply to comment #2)
> This change is very straightforward.  Could
> you tell me which programs use the .pkcs12
> suffix?

The only one I've seen so far is a program to export the digital signature for
the largest ISP in Denmark.

Comment 5

[Wan-Teh Chang]

I agree with Kai that this patch is not necessary.
But .pkcs12 is a reasonable filename suffix for
PKCS #12 files.  So the question is whether we
want to encourage yet another suffix when we already
have two (.p12 and .pfx).  I don't have a strong
opinion either way and am inclined towards no.

Kai, now that we have all the info, we should resolve
this bug quickly (fixed or wontfix).

Comment 6

[Kai Engert (:KaiE:)]

I vote for WONTFIX.
A user can always import file having a strange unexpected extension by switching
to the "all files" filter in the file open dialog.