Closed
Bug 285418
Opened 19 years ago
Closed 19 years ago
Fixes for packaging script
Categories
(Core Graveyard :: XForms, defect)
Core Graveyard
XForms
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: allan, Assigned: allan)
References
()
Details
Attachments
(1 file)
2.03 KB,
patch
|
aaronr
:
review+
|
Details | Diff | Splinter Review |
* Take version from Makefile * Add xforms.js and stage dir. to clean up routine
Assignee | ||
Comment 1•19 years ago
|
||
Attachment #176866 -
Flags: review?(aaronr)
Assignee | ||
Comment 2•19 years ago
|
||
(In reply to comment #1) > Created an attachment (id=176866) [edit] > Patch GARBAGE should include xforms.template too
Comment on attachment 176866 [details] [diff] [review] Patch could you also fix it so that we aren't generating xforms.template and xforms.js in the srcdir if we specified an objdir? toolkit/mozapps/installer/makejs.pl is using the path of the .jst file parameter to figure out where to generate xforms.template. Also, gotta be careful it doesn't break when user is doing srcdir builds. For example, bryner said that this would be a problem if you fix it by copying the .jst file to the objdir, in cases where the objdir is the srcdir the build might stop because you tried to copy the .xpt file onto itself.
Attachment #176866 -
Flags: review?(aaronr) → review-
Assignee | ||
Comment 4•19 years ago
|
||
(In reply to comment #3) > (From update of attachment 176866 [details] [diff] [review] [edit]) > could you also fix it so that we aren't generating xforms.template and > xforms.js in the srcdir if we specified an objdir? > toolkit/mozapps/installer/makejs.pl is using the path of the .jst file > parameter to figure out where to generate xforms.template. Also, gotta be > careful it doesn't break when user is doing srcdir builds. For example, bryner > said that this would be a problem if you fix it by copying the .jst file to the > objdir, in cases where the objdir is the srcdir the build might stop because > you tried to copy the .xpt file onto itself. I do not know the build system good enough for that, I do not use objdir myself, and it sounds like a problem in makejs.pl, so frankly: no.
Assignee | ||
Comment 5•19 years ago
|
||
(In reply to comment #4) > I do not know the build system good enough for that, I do not use objdir myself, > and it sounds like a problem in makejs.pl, so frankly: no. So what do you say Aaron? Can we get this one in, and maybe create a new bug for the above?
Comment on attachment 176866 [details] [diff] [review] Patch ok, if there is a new bug for the xforms.js and xforms.template being created in the srcdir, then I'm fine with this patch.
Attachment #176866 -
Flags: review- → review+
Assignee | ||
Comment 7•19 years ago
|
||
Checked in.
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Updated•8 years ago
|
Product: Core → Core Graveyard
You need to log in
before you can comment on or make changes to this bug.
Description
•