Fixes for packaging script

RESOLVED FIXED

Status

Core Graveyard
XForms
RESOLVED FIXED
13 years ago
2 years ago

People

(Reporter: Allan Beaufour, Assigned: Allan Beaufour)

Tracking

Firefox Tracking Flags

(Not tracked)

Details

(URL)

Attachments

(1 attachment)

(Assignee)

Description

13 years ago
* Take version from Makefile
* Add xforms.js and stage dir. to clean up routine
(Assignee)

Comment 1

13 years ago
Created attachment 176866 [details] [diff] [review]
Patch
Attachment #176866 - Flags: review?(aaronr)
(Assignee)

Comment 2

13 years ago
(In reply to comment #1)
> Created an attachment (id=176866) [edit]
> Patch

GARBAGE should include xforms.template too

Comment 3

13 years ago
Comment on attachment 176866 [details] [diff] [review]
Patch

could you also fix it so that we aren't generating xforms.template and
xforms.js in the srcdir if we specified an objdir? 
toolkit/mozapps/installer/makejs.pl is using the path of the .jst file
parameter to figure out where to generate xforms.template.  Also, gotta be
careful it doesn't break when user is doing srcdir builds.  For example, bryner
said that this would be a problem if you fix it by copying the .jst file to the
objdir, in cases where the objdir is the srcdir the build might stop because
you tried to copy the .xpt file onto itself.
Attachment #176866 - Flags: review?(aaronr) → review-
(Assignee)

Comment 4

13 years ago
(In reply to comment #3)
> (From update of attachment 176866 [details] [diff] [review] [edit])
> could you also fix it so that we aren't generating xforms.template and
> xforms.js in the srcdir if we specified an objdir? 
> toolkit/mozapps/installer/makejs.pl is using the path of the .jst file
> parameter to figure out where to generate xforms.template.  Also, gotta be
> careful it doesn't break when user is doing srcdir builds.  For example, bryner
> said that this would be a problem if you fix it by copying the .jst file to the
> objdir, in cases where the objdir is the srcdir the build might stop because
> you tried to copy the .xpt file onto itself.

I do not know the build system good enough for that, I do not use objdir myself,
and it sounds like a problem in makejs.pl, so frankly: no.
(Assignee)

Comment 5

13 years ago
(In reply to comment #4)
> I do not know the build system good enough for that, I do not use objdir myself,
> and it sounds like a problem in makejs.pl, so frankly: no.

So what do you say Aaron? Can we get this one in, and maybe create a new bug for
the above?

Comment 6

13 years ago
Comment on attachment 176866 [details] [diff] [review]
Patch

ok, if there is a new bug for the xforms.js and xforms.template being created
in the srcdir, then  I'm fine with this patch.
Attachment #176866 - Flags: review- → review+
(Assignee)

Comment 7

13 years ago
Checked in.
Status: NEW → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.