285437 - Ctrl+F when Find bar has focus should Find Again (instead of Ctrl+G?)

Status: NEW

(Toolkit :: Find Toolbar, enhancement, P5)

Description

[Csaba Gabor]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1

OK, firstoff let me say that incremental find is a great thing (once it is
finding text in textareas - see
https://bugzilla.mozilla.org/show_bug.cgi?id=252371), and it's supercool that
this technology that existed 25 years ago is being reintroduced today, but I
can't figure something out, especially since Emacs is even cited at
https://bugzilla.mozilla.org/show_bug.cgi?id=157788.

WHY DO YOU HAVE TO USE CTRL+F to bring up the FAYT (Find As You Type (what was
wrong with the time honoured term Incremental Search?) box at the bottom of the
page, AND THEN CTRL+G to get to instances?  What purpose is this additional key
pressing serving (OK, I realize that if you've already defined what you're
looking for AND you had an aversion to seeing that one line FAYT dialog ...
there might be some utility for you)?  As a touch typist, however, my fingers
ache from all that stretching between the ctrl+f and ctrl+g.  And it's not like
Firefox is the only product with this silliness - pretty much every Microsoft
product has it, too - but why make extra work for the user without utility?

Let's consider:  CTRL+F brings up the FAYT dialog (or gives focus to it) and
then is useless.  GTRL+G does a find next but is useless till you've defined
something for it.  Hey, I know!  Why don't we have ctrl+f bring up the FAYT
dialog (or give focus to it) AND do a CTRL+g.  Then ctrl+g lovers can do what
they've always done, and efficiency lovers like me can be appeased (and be more
efficient) at the same time!  Everybody wins!  Rah, rah Mozilla!

My motto:  If one key [ctrl+s] was good enough for emacs, one key is good enough
for me.


Csaba Gabor from Vienna

Reproducible: Always

Comment 1

[Ben Fowler]

Purely discursive material does not always not always fit well in Bugzilla.

Forward slash / probably does what you want, and is a familar way of 
initiating/continuing a search in many systems.

Comment 2

[Csaba Gabor]

Appreciate the tip on '/', that was news to me, I checked it out.
What it does in Firefox is to initiate a fresh search (ie. like
Ctrl+f followed by a 'delete'.  If there was a previous search
term in the find dialog at the bottom, it is now gone).  Continuing
to press '/' will put the '/' into the find field - as opposed to
doing a ctrl+g (so it doesn't meet my needs).

Notes to self: also, with '/' the find dialog will go away after
a few moments of inactivity.  Furthermore, there is no binking
cursor to let you know where focus is and with keyboard only
the focus stays at the end of the field (though you could insert
text by positioning with the mouse).  In addition, you can't
use '/' in this way when focus is in a textarea/textbox.

So, lest it got lost in the verbiage in my original post, I am advocating:
    Ctrl+f should also do a ctrl+g

Csaba

Comment 3

[Vinay Kumar N.C]

Attachment: patch for bug number 285437

changed shortcut for findAgain from CTRL +G to CTRL +Q.

Comment 4

[Jaime Mitchell (use [e-mail] for email)]

Comment on attachment 182253 [details] [diff] [review]
patch for bug number 285437

[e-mail] you must request review from a relevant peer, you can not
grant your own patches review. Removing review flag.

Comment 5

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

Comment on attachment 182253 [details] [diff] [review]
patch for bug number 285437

Why we need to change accesskey and commandkey "g" to "q"?

Comment 6

[Ben Fowler]

It is probably a typo.

This bug is about making ctrl-F (open search) also do a ctrl-G
(incremental search). It ought to be WONTFIX, but that is not my call.

The error in the reporter's proposal is that the expectation is that ctrl-F
will not alter the scroll of the current page, but that ctrl-G will. Insofar
as that proposal has value, it could be an extension to provide that
option (amongst other emacs settings, no doubt).

Comment 7

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

O.K. I see.

taking. I will implement this as optional.
Ctrl+F will work as Gtrl+G only while the Find Toolbar is having focus.