285456 - Chevron on Bookmarks Toolbar should be clickable all the way to the right

Status: RESOLVED FIXED

(Firefox :: Toolbars and Customization, defect)

Description

[mmortal03]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050306 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050306 Firefox/1.0+

The chevron on the Bookmarks Toolbar cannot be clicked when the mouse is placed
all the way to the right of the screen horizontally.  In contrast, the scroll
bar, Close Tab 'X', Activity Indicator, and Close Window 'X' all can be clicked
and function when accessed from the far right position horizontally.  Uniformity
is key here.

By using the right side of the screen as a guide, the functionality of all of
these buttons is increased, as they are easier to access by only having to
control the vertical placement of the mouse.

Reproducible: Always

Steps to Reproduce:

Comment 1

[please CC darin dot moz at gmail dot com instead]

the "chevron"?  what do you mean exactly?  how about some screenshots?  maybe
i'm just ignorant, but it's not obvious to me what you are requesting.

Comment 2

[Daniel C]

(In reply to comment #1)
> the "chevron"?  what do you mean exactly?  how about some screenshots?  maybe
> i'm just ignorant, but it's not obvious to me what you are requesting.

OK I understand what this means, and I can confirm it using Mozilla/5.0
(Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050305 Firefox/1.0+

Display the bookmarks toolbar. Add bookmarks until they overflow the toolbar
width. The chevron (>>) appears, and it is not clickable from the extreme right,
like the close tab icon, throbber etc. It does make it easier to click when you
only have to consider the vertical position of the cursor, and just fly the
mouse all the way to the right.

Comment 3

[Martijn Wargers (dead)]

The position of the dropmarker with the chevron inside is dependant on the width
of the overflow-padder width:
http://lxr.mozilla.org/seamonkey/source/browser/components/bookmarks/content/bookmarksMenu.js#1011
So this is the spot where it should be adjusted then.

Comment 4

[Martijn Wargers (dead)]

Attachment: Quick and dirty fix

I don't know if this is something that is wanted. I guess so, since the close
tab button is also completely to the right.

Comment 5

[Martijn Wargers (dead)]

Attachment: use pack="end" patch

Or like this. This would solve it also. I don't know how well this would work
in rtl themes (In hindsight, I think the first patch could also go wrong with
rtl themes). That needs to be tested first.

Comment 6

[Martijn Wargers (dead)]

Comment on attachment 177028 [details] [diff] [review]
use  pack="end" patch

Well, I tested with:
*:not([dir="rtl"]){
direction: rtl !important;
}
in my userChrome.css and it seems to work fine with the patch.

Comment 7

[Martijn Wargers (dead)]

There is a patch in bug 269775 that could also fix this. But the patch attached
here has also a simplification that could be desirable.

Comment 8

[Martijn Wargers (dead)]

Comment on attachment 177028 [details] [diff] [review]
use  pack="end" patch

Hmm, no this patch would make bug 269775 even worse.

Comment 9

[Martijn Wargers (dead)]

Fixed by the patch in bug 269775.