Closed Bug 285465 Opened 20 years ago Closed 14 years ago

Warnings in Core.cpp on startup

Categories

(Core Graveyard :: Profile: Roaming, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED WONTFIX

People

(Reporter: mkaply, Assigned: mkaply)

References

Details

Attachments

(1 file)

We currently give an invalid warning in Core.cpp on startup.

Patch coming.
Attached patch Fix for problemSplinter Review
Fix in two places.

1. in BeginSession, don't use NS_ENSURE_SUCCESS - ReadRoamingPrefs can fail
legitimately.

2. the last GetKey can fail in the normal case, so don't NS_ENSURE_SUCCESS it -
just set the value if we succeeded and return the rv.
Comment on attachment 176911 [details] [diff] [review]
Fix for problem

r=BenB
Attachment #176911 - Flags: review+
Assignee: nobody → mkaply
*** Bug 326694 has been marked as a duplicate of this bug. ***
File doesn't exist anymore
Status: NEW → RESOLVED
Closed: 14 years ago
Resolution: --- → WONTFIX
Product: Core → Core Graveyard
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: