Tree Progressmeter Cells should use os theme progresschunk

NEW
Unassigned

Status

()

Core
XUL
14 years ago
9 years ago

People

(Reporter: Gary van der Merwe, Unassigned)

Tracking

Trunk
x86
All
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(3 attachments, 3 obsolete attachments)

(Reporter)

Description

14 years ago
User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050310 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050310 Firefox/1.0.1

Tree Progressmeter Cells currently only render a sized image. They sould use the
OS theme style.

Reproducible: Always

Steps to Reproduce:
(Reporter)

Updated

14 years ago
Status: NEW → ASSIGNED
(Reporter)

Updated

14 years ago
Assignee: jan → garyvdm
Status: ASSIGNED → NEW
(Reporter)

Comment 1

14 years ago
Created attachment 176952 [details]
Testcase
(Reporter)

Comment 2

14 years ago
Created attachment 176954 [details] [diff] [review]
Patch v0.1

This is what I have done so far. Lots more to still do.
(Reporter)

Comment 3

13 years ago
Created attachment 182330 [details] [diff] [review]
Patch v0.2

1. Moved to trunk code.
2. Will still show image if one is specfied
(Reporter)

Updated

13 years ago
Attachment #176954 - Attachment is obsolete: true
(Reporter)

Comment 4

13 years ago
Created attachment 182335 [details] [diff] [review]
Patch v0.3

I've now added an extra style class. So you have a style for the whole meter,
and a style for the bar.
Attachment #182330 - Attachment is obsolete: true
(Reporter)

Comment 5

13 years ago
Created attachment 182337 [details]
Screen Shot Before and After
(Reporter)

Updated

13 years ago
Attachment #182337 - Attachment is patch: false
Attachment #182337 - Attachment mime type: text/plain → image/png
(Reporter)

Comment 6

13 years ago
Now I need to do some testing on other OS's. 
Status: NEW → ASSIGNED
(Reporter)

Comment 7

13 years ago
Created attachment 185942 [details] [diff] [review]
Patch 0.4

Just some a few things I've done to improve this patch:
Add changes to qute and pinstripe
Changed paddding on the outer box to correct the rendering in kde.
Attachment #182335 - Attachment is obsolete: true
(Reporter)

Updated

13 years ago
OS: Windows XP → All
(Reporter)

Comment 8

13 years ago
For the record, email conversation with Neil Rashbrook

Gary van der Merwe wrote:
> I saw this comment: Bug 226491 c19 and thought that maybe you can help
> me sort out undetermined side of things.
>
> I don't think it is possible to use the same solution as for Bug
> 226491, as I don't believe that it is possible to attach a xbl to a
> cell (only to the whole tree). Maybe I am wrong though.
>
> Do you have any ideas on how I can do this?

Neil Rashbrook wrote:
> No, XBL cannot be attached to tree parts. I doubt that you would be able
> to duplicate the effect of the xbl, but you might be able to emulate the
> effect if you could set a timer to repaint the cell using different
> start and end offsets for the progress chunk thus animating the chunk.
> However I don't know how you would be able to tell when to start or stop
> the animation.

Updated

10 years ago
Component: XP Toolkit/Widgets: Trees → XUL
QA Contact: xptoolkit.widgets
(Reporter)

Updated

9 years ago
Assignee: garyvdm → nobody
Status: ASSIGNED → NEW
You need to log in before you can comment on or make changes to this bug.