285617 - FAYT returns link as first result, ctrl+enter opens link in new tab instead of highlighing

Status: RESOLVED INVALID

(Toolkit :: Find Toolbar, defect)

Description

[Martin Meyer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050307 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050307 Firefox/1.0+

When using FAYT today, I noticed that pressing ctrl+enter when focused on the
findbar didn't always highlight the results like I expected it to.  Instead, I
was getting a new tab opened with the link the findbar had focused on.  New tabs
only open if the first result that is found is a link, otherwise highlighting
turns on and everything is happy.

This problem is only present when activating the findbar with / or ', not with
crtl-f.  I noticed that just about every other keyboard shortcut had bugs
reported for it, but didn't find one for this.

Reproducible: Always

Steps to Reproduce:
1. Open any webpage
2. Activate the findbar by pressing / or '
3. Type a string that will match a link first (bugzilla is a good place to try
this, just enter the first few digits of a bug number)
4. Press ctrl+enter

Actual Results:  
A new tab is opened with the link that was found first.

Expected Results:  
All results on the page should be highlighted.

This bug may depend on bug 269766, but I don't think it is a duplicate because
that bug only describes the key conflict, not the problem that results from it.

Comment 1

[Gervase Markham [:gerv]]

This is an automated message, with ID "auto-resolve01".

This bug has had no comments for a long time. Statistically, we have found that
bug reports that have not been confirmed by a second user after three months are
highly unlikely to be the source of a fix to the code.

While your input is very important to us, our resources are limited and so we
are asking for your help in focussing our efforts. If you can still reproduce
this problem in the latest version of the product (see below for how to obtain a
copy) or, for feature requests, if it's not present in the latest version and
you still believe we should implement it, please visit the URL of this bug
(given at the top of this mail) and add a comment to that effect, giving more
reproduction information if you have it.

If it is not a problem any longer, you need take no action. If this bug is not
changed in any way in the next two weeks, it will be automatically resolved.
Thank you for your help in this matter.

The latest beta releases can be obtained from:
Firefox:     http://www.mozilla.org/projects/firefox/
Thunderbird: http://www.mozilla.org/products/thunderbird/releases/1.5beta1.html
Seamonkey:   http://www.mozilla.org/projects/seamonkey/

Comment 2

[Daniel Wang]

Invalid. Ctrl+Enter is the keyboard shortcut to open link in a new tab. I don't
think the Find Bar should steal keyboard shortcut (otherwise, Enter would become
"find next" instead of "open the link")