285711 - Screen reader users don't get alert messages

Status: RESOLVED FIXED

(Firefox :: Disability Access, defect)

Description

[Aaron Leventhal]

When an alert message pops up, screen reader users do not get a verbal
notification of it.

To reproduce:
Go to http://ted.mielczarek.org/code/mozilla/extensiondev/
Use the install link

Notice that the security warning comes up, but no event is fired to indicate
that it has.

We should use ROLE_ALERT to contain the entire alert, and fire EVENT_ALERT when
it pops up.

Comment 1

[Aaron Leventhal]

Attachment: 1) Create special accessibles for messagepopups, 2) Fire EVENT_ALERT when it pops up

Comment 2

[Aaron Leventhal]

Attachment: Removes some extraneous changes

Comment 3

[Aaron Leventhal]

Attachment: Move code into new nsXULAlertAccessible.* files where it belongs

Comment 4

[Philip K. Warren]

Comment on attachment 177136 [details] [diff] [review]
Move code into new nsXULAlertAccessible.* files where it belongs

>Index: accessible/public/nsIAccessibilityService.idl

Bump UUID?

>Index: accessible/src/xul/nsXULAlertAccessible.cpp
...
>+#if 0
>+// We don't need this, but the AT will need to read all of the alert's children
>+// when it receives EVENT_ALERT on a ROLE_ALERT
>+NS_IMETHODIMP nsXULAlertAccessible::GetName(nsAString &aName)
>+{

Can you explain why you left all this code in but #if 0'd?

You should probably have bryner or neil look over your event code.

Comment 5

[Aaron Leventhal]

Comment on attachment 177136 [details] [diff] [review]
Move code into new nsXULAlertAccessible.* files where it belongs

Thanks I'll bump the UUID. I've left the code in there because we might want to
do something like that at some point, so that the screen reader vendor doesn't
have to iterate through all of the children and speak them or show them on the
Braille display, on this special alert event. It would be better if the screen
reader does do that, if we can get them to do it -- so that buttons and other
UI elements are differentiated from the message itself. I was going to remove
this once I have at least one screen reader vendor doing it on their end.

Comment 6

[[e-mail]]

Comment on attachment 177136 [details] [diff] [review]
Move code into new nsXULAlertAccessible.* files where it belongs

Even with more context I suggest someone with more familiarity with the code
should review this.

Comment 7

[Henry Jia]

Comment on attachment 177136 [details] [diff] [review]
Move code into new nsXULAlertAccessible.* files where it belongs

There is a '{' missed in mozilla/toolkit/content/widgets/browser.xml, other
than that, seems good. Please correct before checking in.

Comment 8

[Aaron Leventhal]

Checking in toolkit/content/widgets/tabbrowser.xml;
/cvsroot/mozilla/toolkit/content/widgets/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.73; previous revision: 1.72
done
Checking in accessible/public/nsIAccessibilityService.idl;
/cvsroot/mozilla/accessible/public/nsIAccessibilityService.idl,v  <-- 
nsIAccessibilityService.idl
new revision: 1.45; previous revision: 1.44
done
Checking in accessible/src/base/nsAccessibilityService.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessibilityService.cpp,v  <-- 
nsAccessibilityService.cpp
new revision: 1.127; previous revision: 1.126
done
Checking in accessible/src/base/nsAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsAccessible.cpp,v  <--  nsAccessible.cpp
new revision: 1.133; previous revision: 1.132
done
Checking in accessible/src/base/nsRootAccessible.cpp;
/cvsroot/mozilla/accessible/src/base/nsRootAccessible.cpp,v  <-- 
nsRootAccessible.cpp
new revision: 1.111; previous revision: 1.110
done
Checking in accessible/src/msaa/nsAccessibleWrap.cpp;
/cvsroot/mozilla/accessible/src/msaa/nsAccessibleWrap.cpp,v  <-- 
nsAccessibleWrap.cpp
new revision: 1.20; previous revision: 1.19
done
Checking in accessible/src/xul/Makefile.in;
/cvsroot/mozilla/accessible/src/xul/Makefile.in,v  <--  Makefile.in
new revision: 1.16; previous revision: 1.15
done

Comment 9

[Firefox Bug Husbandry Bot]

https://bugzilla.mozilla.org/show_bug.cgi?id=1527381