285797 - ExecCommand only working for the first selection instance

Status: REOPENED

(Core :: DOM: Editor, defect)

Description

[Martijn Wargers (dead)]

See upcoming testcase.
I would expect that execCommand to work for all three selection instances.
Instead it works for only the first selection instance.
The 'createlink' execCommand works for the first two selection instances for
some reason.

Comment 1

[Martijn Wargers (dead)]

Attachment: Testcase

Comment 2

[Jaquez]

I am running the test case in FF1.1 without the patch so keep that in mind when
reading my comments.

If I click on 'createlink' once (this creates the multiple selections for me),
'bold', 'italic', and 'createlink' work as expected as well as both 'delete'
buttons.  What's even more interesting, is that if 'createlink' is clicked
first, then either 'bold', 'italic', or both are clicked next, 'unlink' works
properly as well whereas if 'bold' or 'italic' are not selected before 'unlink',
it works correctly but then forgets the selections.

I wonder if it would help if the test case started with the multiple selections
already made.  Also, Martijn, I would be willing to look at the code of the
relevant execCommands to see if I can determine what it is about them that
causes the varying behavior if you could point me in the right direction.

Comment 3

[Martijn Wargers (dead)]

The three selection instances should be visible directly, so it's rather strange
that you're not seeing that.

I don't really know any c code, but perhaps this is the place where a large part
of the execcomands are carried out.
http://lxr.mozilla.org/seamonkey/source/editor/libeditor/html/nsHTMLEditorStyle.cpp#127

but this seems already take into account multiple selections:
http://lxr.mozilla.org/seamonkey/source/editor/libeditor/html/nsHTMLEditorStyle.cpp#168
So maybe this is unrelated.

Some more testing:
-clicking multiple times on a 'execcommand' button takes the following selection
and makes it bold/italic/underlined whatever your chose.
-It doesn't matter if the selections are in the same node, or not, the bug is
always there.

Comment 4

[Kathleen :Brade]

I assume this bug also applies to Composer and nVu.  Can someone confirm that it
is not specific to Midas?

Comment 5

[Martijn Wargers (dead)]

Yes, this also applies to Composer. I just applied the patch from bug 73373 in
my debug build, and it exhibits the same behavior as the midas/richedit testcase.