Closed Bug 28588 Opened 26 years ago Closed 25 years ago

Enter should search on Find on this Page

Categories

(Core :: XUL, defect, P3)

Product:
Core
Component:
XUL
Platform:
x86
Linux
Type:
defect

Tracking

()

Status:
VERIFIED FIXED

People

(Reporter: rzach, Assigned: law)

References

Details

Hitting Enter in the Find on this Page dialog should be like clicking OK (find or find again, without dismissing window). Right now, it does nothing. Linux build 2000.02.19.09
Sounds like the dialog doesn't pick up the key bindings from commonDialog.xul Don, I'm giving this to you, because I luv u :-)
Assignee: saari → don
QA Contact: paulmac → sairuh
wouldn't this be considered a dup of bug 29216?
On 4x in Linux, Enter doesn't dismiss the dialog, but does a "Find Again". (The button in the dialog is labelled "Find" not "OK"). So if you make this a dup, please note in the other bug. Or maybe you don't need to, since the shortcut would do whatever the button does (which also doesn't dismiss the dialog). I filed a bug like bug 29216 once before, but was told we need separate bugs for each dialog.
Assignee: don → law
Depends on: 29216
Add dependency on 29216
*** Bug 30083 has been marked as a duplicate of this bug. ***
*** Bug 30155 has been marked as a duplicate of this bug. ***
*** Bug 31616 has been marked as a duplicate of this bug. ***
From bug 31616: Esc should dismiss the Find dialog.
Status: NEW → ASSIGNED
Simple fix: there was a missing <keyset id="keyset"/> element in finddialog.xul. Will check this in and resolve bug later today.
*** Bug 32524 has been marked as a duplicate of this bug. ***
Finally got to this (crises arose in the interim, as usual). Fix checked in.
Status: ASSIGNED → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
(and Esc dismisses the dialog, too. :-) verified as fixed with the following opt comm bits: linux 2000.03.28.09 macOS 2000.03.28.10 winNT 2000.03.28.09
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.