285981 - [FIX]No alt text displayed with broken (security-blocked) image

Status: RESOLVED FIXED

(Core :: Layout: Images, Video, and HTML Frames, defect, P1)

Description

[Boris 'pi' Piwinger]

Mozilla/5.0 (Windows; U; Win98; en-US; rv:1.8b) Gecko/20050217

On http://piology.org/ie/ look for the following text:
"Bilder" an, die keine sind:

Behind it is a broken image. The alt text ("[kaputtes Bild]") is not shown.

pi

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Security Error: Content at http://piology.org/ie/ may not load or link to
view-source:file:///c:%5Cwindows%5Cwin.ini.

Comment 2

[Boris Zbarsky [:bzbarsky]]

We don't show alt text for images that are blocked in user preferences
explicitly or blocked by the security manager.

We could change that easily enough, if desired.  It's a one-line change at
http://lxr.mozilla.org/seamonkey/source/content/base/src/nsContentUtils.cpp#1835
(to use REJECT_TYPE).

The question is, should we?

Comment 3

[Boris 'pi' Piwinger]

OK, I see the point. I believe the alt text was displayed when I created the 
page, though. I think it would make sense, the text could have some reasonable 
function not usable without the text.

pi

Comment 4

[Boris Zbarsky [:bzbarsky]]

Yes, this behavior changed recently....

FWIW, I think it does make sense to show alt text for images blocked by the
security manager.  Ian, what do you think?

Comment 5

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

After some more thought, I think any status that's not REJECT_SERVER should
show the alt text (and that security should lead to a REJECT_REQUEST status).

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 178630 [details] [diff] [review]
Proposed fix

sr=jst

Comment 7

[Boris Zbarsky [:bzbarsky]]

Fixed.

Comment 8

[Peter van der Woude [:Peter6]]

could this fix have caused regression bug 287842 ?

Comment 9

[Frank Wein [:mcsmurf]]

*** Bug 299025 has been marked as a duplicate of this bug. ***