286003 - Direct access to summarize-time.cgi when time tracking is off generates an error

Status: RESOLVED FIXED

(Bugzilla :: Creating/Changing Bugs, defect)

Description

[Vlad Dascalu]

Direct access tosummarize-time.cgi when time tracking is off generates an error.

This is probably due to the following line:

+ThrowUserError("timetracking_access_denied") unless 
...

from the patch commited in bug 250410. There is no timetracking_access_denied
error in the user-error.html.tmpl template.

2.20 blocker, probably.

Comment 1

[Shane H. W. Travis]

Attachment: Code patch for tip

Fixes this in a generic way, using the standard auth_failure error.

Comment 2

[Jouni Heikniemi]

Comment on attachment 177915 [details] [diff] [review]
Code patch for tip

>-ThrowUserError("timetracking_access_denied") unless 
>-    UserInGroup(Param("timetrackinggroup"));
>+UserInGroup(Param("timetrackinggroup"));
>+    || ThrowUserError("auth_failure", {group  => "time-tracking",
>+                                       action => "access",
>+                                       object => "timetracking_summaries"});

Apart from the fact that this doesn't compile (what's that ; doing after
UserInGroup anyway), it's fine ;-)

Remove that extra semicolon and test it (I did, but still), and r=jouni.

Comment 3

[Frédéric Buclin]

Checking in summarize_time.cgi;
/cvsroot/mozilla/webtools/bugzilla/summarize_time.cgi,v  <--  summarize_time.cgi
new revision: 1.5; previous revision: 1.4
done
Checking in template/en/default/global/user-error.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/global/user-error.html.tmpl,v
 <--  user-error.html.tmpl
new revision: 1.103; previous revision: 1.102
done