286081 - SVG build page Mac OS X information is outdated/invalid.

Status: VERIFIED FIXED

(www.mozilla.org :: General, defect)

Description

[Arthur Wiebe]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050312 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b2) Gecko/20050312 Firefox/1.0+

The Mac OS X build and download information is outdated and some in invalid. I
will attach a patch.

Reproducible: Always

Comment 1

[Arthur Wiebe]

Attachment: Updates build.html

Comment 2

[Anne (:annevk)]

Comment on attachment 177370 [details] [diff] [review]
Updates build.html

>-      <h4 style="background-color:#C7FFC7;">Libart</h4> 
>+      <h5 style="border-bottom: 0px">Download:</h5>

Don't skip heading levels. Actually, you might want to insert <div
class="section"> into the file according to the Markup Guidelines.


>+      <a id="mac_cairo_dl"></a>
>+      <h4 style="background-color:#C7FFC7;">Cairo</h4>

The A element should either be inside the H4 element wrapped around "Cairo" or
the H4 element should use an ID attribute.

Also, do not use the STYLE attribute. If you have issues with the general
styling of headings file a bug against that.


>       <pre>
>-        -enable-crypto 
>-        -enable-svg 
>-        -enable-calendar 
>-        -enable-svg-renderer=libart
>-        -enable-optimize="-O2"
>+        ac_add_options --enable-svg
>       </pre>

Please use a CLASS attribute on the PRE element while you are at it. (These
comments apply to the whole document and diff. I choose specific snippets, but
the comments are not restricted to those.)

Comment 3

[Jonathan Watt [:jwatt]]

(In reply to comment #2)
> (From update of attachment 177370 [details] [diff] [review] [edit])
> >-      <h4 style="background-color:#C7FFC7;">Libart</h4> 
> >+      <h5 style="border-bottom: 0px">Download:</h5>
> 
> Don't skip heading levels. Actually, you might want to insert <div
> class="section"> into the file according to the Markup Guidelines.

No, what you have is consistant with the rest of the document. Changes like that
should be done for the whole document. Anne and I can argue about that later. ;-)


> >+      <a id="mac_cairo_dl"></a>
> >+      <h4 style="background-color:#C7FFC7;">Cairo</h4>
> 
> The A element should either be inside the H4 element wrapped around "Cairo" or
> the H4 element should use an ID attribute.

My preference is for the former. It's more backwards compatible.


> Also, do not use the STYLE attribute. If you have issues with the general
> styling of headings file a bug against that.

In this case do use the 'style' attribute. It's consistant with the rest of the
document. Again, Anne and I can argue about changing that for the whole doc later.


> >       <pre>
> >-        -enable-crypto 
> >-        -enable-svg 
> >-        -enable-calendar 
> >-        -enable-svg-renderer=libart
> >-        -enable-optimize="-O2"
> >+        ac_add_options --enable-svg
> >       </pre>
> 
> Please use a CLASS attribute on the PRE element while you are at it. (These
> comments apply to the whole document and diff. I choose specific snippets, but
> the comments are not restricted to those.)
> 

Again, that's not something for this bug.

I'll add my own review comments for your patch once I've finished off a few
things. If you're going to submit patches for a bug, feel free to assign it to
yourself BTW. I'll check in the accepted patch for you if needs be.

Comment 4

[Arthur Wiebe]

Perhaps the entire document should be rewritten?

I did not add/change any formatting except for what was needed, and prefer not
to use the style attribute and the a element for anchors but decided not to
change that.

Should I just redo the entire page?

Comment 5

[Jonathan Watt [:jwatt]]

No, I was planning on updating the page for Mac and on updating the styling anyway.

Comment 6

[Arthur Wiebe]

Attachment: Updates build.html

This patch fixes the heading level issues.

Comment 7

[Arthur Wiebe]

Attachment: When edited in Nvu

This is what happens when I edit the page in Nvu. (Hint: A rewrite)

Comment 8

[Jonathan Watt [:jwatt]]

Comment on attachment 177384 [details] [diff] [review]
Updates build.html

>Index: html/projects/svg/build.html
>===================================================================
>RCS file: /www/mozilla-org/html/projects/svg/build.html,v
>retrieving revision 1.22
>diff -u -r1.22 build.html
>--- html/projects/svg/build.html	9 Mar 2005 12:19:26 -0000	1.22
>+++ html/projects/svg/build.html	14 Mar 2005 17:43:48 -0000
>@@ -40,7 +40,7 @@
>         <td></td>
>         <th style="background-color:#C7C7FF;">Windows</th>
>         <th style="background-color:#FFC7C7;">Linux</th>
>-        <th style="background-color:#C7FFC7;">Macintosh</th>
>+        <th style="background-color:#C7FFC7;">Mac OS X</th>
>       </tr>
>       <tr>
>         <th>GDI+</th>
>@@ -62,17 +62,19 @@
>           <a href="#linux_libart_build">Build</a>
>         </td>
>         <td style="background-color:#F2FFF2;">
>-          <a href="#mac_builds">Build</a>
>+          <a href="#mac_libart_dl">Download</a> |
>+          <a href="#mac_libart_build">Build</a>
>         </td>
>       </tr>
>       <tr>
>-        <th>cairo</th>
>+        <th>Cairo</th>

No change. It's "cairo" not "Cairo". Make sure it's correct in the rest of your
diff too.


>         <td style="background-color:#F2F2FF;">-</td>
>         <td style="background-color:#FFC7C7;">
>           <a href="#linux_cairo_build">Build</a>
>         </td>
>         <td style="background-color:#C7FFC7;">
>-          <a href="#mac_builds">Build</a>
>+          <a href="#mac_cairo_dl">Download</a> |
>+          <a href="#mac_cairo_build">Build</a>
>         </td>
>       </tr>
>     </table>
>@@ -366,79 +368,66 @@
>     <div style="border: black solid 1px; padding:10px; margin:5px; background-color:#F2FFF2;">
> 
>       <a id="mac_builds"></a>
>-      <h2>Macintosh</h2>
>+      <h2>Mac OS X</h2>

Include
+      <h4 style="background-color:#C7FFC7;">cairo</h4> 
here.


>+      <p>
>+        By default Mac OS X builds now use Cairo. In order to use Libart instead of Cairo, you must use the -enable-svg-renderer=libart flag.
>+      </p>
> 
>-      <h4 style="background-color:#C7FFC7;">Libart</h4> 
>+      <h3 style="border-bottom: 0px">Download:</h3>

h3 -> h5


>+      <a id="mac_cairo_dl"></a>

Put this anchor around "Download:" in the header above.


>+      <h4 style="background-color:#C7FFC7;">Cairo</h4>

Wrong place for this.


>       <p>
>-        Libart is currently the only renderer available for Mac OS X. There's
>-        work being made on a native Cabon based interface / rendering engine in
>-        bug 214912 <a
>-        href="https://bugzilla.mozilla.org/show_bug.cgi?id=214912">Implement the
>-        SVG rendering back end using Quartz 2D</a>.
>+        Firefox builds using Cairo are available from <a href="http://artooro.spymac.net/firefox/">http://artooro.spymac.net/firefox/</a>. 
>+        These builds are usually updated daily Monday to Saturday.
>       </p>

I'll discuss with the SVG Project lead whether we want to link to your builds
at this stage. If we do, you should also include your email address and a
statement that questions regarding these builds should be sent to you (yes, I
know your email address is on your site).


>       <a id="mac_libart_dl"></a>
>-      <h5 style="border-bottom: 0px">Download:</h5>
>-
>+      <h4 style="background-color:#C7FFC7;">Libart</h4>

Anchor around "Download:" header text, which should come after the "Libart"
header.


>       <p>
>-        Mac OS X libart builds are regularly built by <a
>+        Mozilla Suite &amp; Firefox builds using Libart are regularly built by <a
>         href="mailto:[e-mail]">Bjarne D Mathiesen</a>. You can
>         find the latest build at <a

I think you can probably remove the "regularly".


>-        href="http://mozilla.mathiesen.info/svg/Mozilla-Mac-latest.dmg">http://mozilla.mathiesen.info/svg/Mozilla-Mac-latest.dmg</a>.
>+        href="http://mozilla.mathiesen.info/svg/">http://mozilla.mathiesen.info/svg/</a>.

I'd prefer you keep the "Mozilla-Mac-latest.dmg" - at least in the link text.


>         At present, there's only the promise of these being built based upon
>-        the official release source tarballs. A Mac OS X Firefox enabled with
>-        SVG enabled is being attempted.
>+        the official release source tarballs.
>       </p>
> 
>+      <a id="mac_cairo_build"></a>
>+      <h3 style="border-bottom: 0px">Build From Source with Cairo:</h3>

Please don't change the existing structure of the document. Keep the cairo
stuff together, and the libart stuff together.


>       <p>
>-        The configuration of these builds is
>+        To build Mozilla SVG with the Cairo backend on Mac OS X, set up a
>+        .mozconfig configuration file containing at least the following line.
>       </p>
> 
>       <pre>
>-        -enable-crypto 
>-        -enable-svg 
>-        -enable-calendar 
>-        -enable-svg-renderer=libart
>-        -enable-optimize="-O2"
>+        ac_add_options --enable-svg
>       </pre>
> 
>       <p>
>-        Please direct all questions regarding these builds to
>-        <a href="mailto:[e-mail]">Bjarne D Mathiesen</a>.
>+        Now pull/build:
>       </p>
> 
>+      <pre>
>+        cd mozilla; make -w -f client.mk
>+      </pre>
>+      
>       <a id="mac_libart_build"></a>
>-      <h5 style="border-bottom: 0px">Build from source:</h5>
>+      <h3 style="border-bottom: 0px">Build From Source with Libart:</h3>
> 
>       <p>
>-        To build Mozilla SVG with the libart backend on Mac OS X, set up a
>-        .mozconfig configuration file containing at least the lines
>+        To build Mozilla SVG with the Libart backend on Mac OS X, set up a
>+        .mozconfig configuration file containing at least the following lines.
>       </p>
> 
>       <pre>
>-        ac_add_options --enable-default-toolkit=mac
>-        ac_add_options --disable-tests
>-        ac_add_options --disable-debug
>-        ac_add_options --enable-optimize="-O2"
>-        ac_add_options --enable-crypto
>-        ac_add_options --enable-calendar
>-        ac_add_options --without-system-nspr
>-        ac_add_options --without-system-zlib
>-        ac_add_options --without-system-jpeg
>-        ac_add_options --without-system-png
>-        ac_add_options --without-system-mng
>         ac_add_options --enable-svg
>-        ac_add_options --enable-svg-renderer=libart
>-        mk_add_options MOZ_CO_MODULE=mozilla/other-licenses/libart_lgpl
>+        ac_add_options --enable-svg-renderer=libart
>        mk_add_options MOZ_CO_MODULE=mozilla/other-licenses/libart_lgpl
>       </pre>
> 
>       <p>
>-        Note that the Libart backend must be explicitly enabled since the
>-        default SVG backend for Macintosh is cairo.
>-      </p>
>-
>-      <p>
>         Now pull/build:
>       </p>
>

Comment 9

[Arthur Wiebe]

Thanks for taking the time.

I actually sent an email to Alex Fritze about this and he said, "Nice. We should
link to your page from the build page then."

Most of the issues you noted are fixed in the "When edited in Nvu" patch but the
text formatting is really bad. Later today I'll do a new and better one.

Comment 10

[Arthur Wiebe]

Attachment: build.html patch

This patch should do it.

Cairo, I mean cairo, is now spelled correctly :)

I did not mess up with the hx levels.

And whatever else there was wrong.

Comment 11

[Jonathan Watt [:jwatt]]

Comment on attachment 177606 [details] [diff] [review]
build.html patch

>@@ -417,35 +435,19 @@
>       </p>
> 
>       <pre>
>-        ac_add_options --enable-default-toolkit=mac

Are you sure this isn't needed for libart? If not, please leave it in.


>-
>+      
>       <pre>
>-        cd mozilla; make -w -f client.mk
>+        cd mozilla; make -f client.mk
>       </pre>
>-
>+      
>     </div>

Please don't add whitespace to the blank lines.

r=jwatt with these nits fixed. Thanks! Do you need someone to check in for you?

Comment 12

[Arthur Wiebe]

(In reply to comment #11)
> (From update of attachment 177606 [details] [diff] [review] [edit])
> >@@ -417,35 +435,19 @@
> >       </p>
> > 
> >       <pre>
> >-        ac_add_options --enable-default-toolkit=mac
> 
> Are you sure this isn't needed for libart? If not, please leave it in.
> 

That does nothing. It's only useful if you want to do a GTK build on Mac or
something like that.

> 
> >-
> >+      
> >       <pre>
> >-        cd mozilla; make -w -f client.mk
> >+        cd mozilla; make -f client.mk
> >       </pre>
> >-
> >+      
> >     </div>
> 
> Please don't add whitespace to the blank lines.
> 
> r=jwatt with these nits fixed. Thanks! Do you need someone to check in for you?
> 

I have no CVS access so yes, someone else needs to check it in.

Thanks.

Comment 13

[Jonathan Watt [:jwatt]]

Checked in without whitespace on blank lines, and with the sentence to highlight
that -enable-svg-renderer=libart is required for libart left in.

Checking in mozilla-org/html/projects/svg/build.html;
/cvsroot/mozilla-org/html/projects/svg/build.html,v  <--  build.html
new revision: 1.23; previous revision: 1.22
done

Marking fixed. Thanks Arthur.