Closed Bug 286191 Opened 20 years ago Closed 20 years ago

UMR in nsTypeAheadFind::PrefsReset

Categories

(SeaMonkey :: Find In Page, defect)

Product:
SeaMonkey
Component:
Find In Page
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED

People

(Reporter: ajschult784, Assigned: ajschult784)

References

(
URL
)

Details

Attachments

(1 file, 1 obsolete file)

the right patch
1.04 KB, patch
aaronlev
: review+
jst
: superreview+
Details | Diff | Splinter Review 
Conditional jump or move depends on uninitialised value(s)
  at 0x1CC42069: nsTypeAheadFind::PrefsReset() (nsTypeAheadFind.cpp:335)

isTimeoutEnabled needs to be initialized (false?)
Attached patch initialize to false (obsolete) — — Splinter Review 

        Attachment #177459 -
        Flags: superreview?(jst)

        Attachment #177459 -
        Flags: review?(aaronleventhal)

    
    

    
  
Comment on attachment 177459 [details] [diff] [review]
initialize to false

I don't know anything about this code. Here are some folks that do:
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/profile/pref-migrator/src/nsP
refMigration.cpp

I suggest you request r= from one of them.

        Attachment #177459 -
        Flags: review?(aaronleventhal)

    
    

    
  
Comment on attachment 177459 [details] [diff] [review]
initialize to false

oops

        Attachment #177459 -
        Attachment is obsolete: true

        Attachment #177459 -
        Flags: superreview?(jst)

    
    

    
  

      
      
      
      

        Attached patch
          
          
        the right patch
        — 
          — Splinter Review
      

    


  

        Attachment #177489 -
        Flags: superreview?(jst)

        Attachment #177489 -
        Flags: review?(aaronleventhal)

    
  

        Attachment #177489 -
        Flags: review?(aaronleventhal) → review+

    
    

    
  
Comment on attachment 177489 [details] [diff] [review]
the right patch

sr=jst

        Attachment #177489 -
        Flags: superreview?(jst) → superreview+

    
    

    
  
This looks like it was checked in. Can it be resolved?

    
    

    
  
oops.
resolving FIXED
Status: NEW → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Product: Core → SeaMonkey

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: