286205 - Bugzilla Header shown twice if I try to add user without specifying the password

Status: RESOLVED FIXED

(Bugzilla :: Administration, task)

Description

[Rajesh]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.6) Gecko/20050225 Firefox/1.0.1

http://bugzilla_url/editusers.cgi?action=add

try to add a user without specifying password.

Bugzilla header is shown twice.

Reproducible: Always

Comment 1

[Marc Schumann [:Wurblzap]]

I cannot reproduce on current tip. Which version are you using?

Comment 2

[Rajesh]

Reproducible in both Version 2.17.6/Version 2.18 

Comment 3

[Hamid Tehrani]

I can reproduce this in 2.19.2 also.

Comment 4

[Frédéric Buclin]

This has been fixed on the trunk by bug 119485. I can reproduce on the 2.18
branch. Looks like a $vars->{'header_done'} or equivalent is not set correctly.
Marc, are you interested in fixing this bug? It should be trivial.

Comment 5

[Marc Schumann [:Wurblzap]]

Attachment: Branch patch

Removing dead code from callsites, too.

Comment 6

[Frédéric Buclin]

Comment on attachment 186901 [details] [diff] [review]
Branch patch

>     if (length($password) < 3) {
>-        ThrowUserError("password_too_short");
>+        ThrowUserError("password_too_short", $main::vars);
>     } elsif (length($password) > 16) {
>-        ThrowUserError("password_too_long");
>+        ThrowUserError("password_too_long", $main::vars);
>     } elsif ((defined $matchpassword) && ($password ne $matchpassword)) {
>-        ThrowUserError("passwords_dont_match");
>+        ThrowUserError("passwords_dont_match", $main::vars);

Please replace $main::vars by $::vars and carry forward my r+.

For the record, this "hack" is necessary and specific to 2.18 as editusers.cgi
has not been templatized yet.

Comment 7

[Marc Schumann [:Wurblzap]]

Attachment: Branch patch

Using $::vars instead of $main::vars. Moving r+ forward.

Comment 8

[Frédéric Buclin]

Checking in editusers.cgi;
/cvsroot/mozilla/webtools/bugzilla/editusers.cgi,v  <--  editusers.cgi
new revision: 1.61.2.7; previous revision: 1.61.2.6
done
Checking in globals.pl;
/cvsroot/mozilla/webtools/bugzilla/globals.pl,v  <--  globals.pl
new revision: 1.270.2.11; previous revision: 1.270.2.10
done
Checking in token.cgi;
/cvsroot/mozilla/webtools/bugzilla/token.cgi,v  <--  token.cgi
new revision: 1.26.2.1; previous revision: 1.26
done