Closed Bug 286282 Opened 20 years ago Closed 20 years ago

Thunderbird should use mozilla\toolkit's alert code

Categories

(Thunderbird :: Mail Window Front End, defect)

Product:
Thunderbird
Component:
Mail Window Front End
Platform:
x86
Windows XP
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

(Not tracked)

Status:
RESOLVED FIXED
Milestone:
Thunderbird1.1

People

(Reporter: mscott, Assigned: mscott)

Details

Attachments

(2 files, 1 obsolete file)

the fix
17.15 KB, patch
Details | Diff | Splinter Review
Remove standalone composer ifdefs also [checked in]
1.48 KB, patch
mvl
: review+
Details | Diff | Splinter Review 
we currently use the version in xpfe.

I also tried to move us to the download manager in toolkit but it became too big
a job so I went back to just this patch to get this in first.
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird1.1
Attached patch the fix — — Splinter Review 
1) stop building xpfe\components\alerts for thunderbird
2) start building toolkit\components\alerts for thunderbird
3) port an old r/sr'ed xpfe API change for nsIAlertsService to mozilla\toolkit
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
FWIW, this change broke the XULRunner build.
It also broke sunbird. I think it broke everything not firefox or thunderbird.
Attached patch fix sunbird (obsolete) — — Splinter Review 

        Attachment #177614 -
        Flags: review?(benjamin)

    
    

    
  


  

        Attachment #177614 -
        Attachment is obsolete: true

        Attachment #177615 -
        Flags: review?(mvl)

    
    

    
  
Comment on attachment 177615 [details] [diff] [review]
Remove standalone composer ifdefs also [checked in]

>-ifdef MOZ_STANDALONE_COMPOSER

The removal of the endif that should go with this is missing.

r=mvl with that fixed.

        Attachment #177615 -
        Flags: review?(mvl) → review+

    
  

        Attachment #177614 -
        Flags: review?(benjamin)

    
  

        Attachment #177615 -
        Attachment description: Remove standalone composer ifdefs too → Remove standalone composer ifdefs also [checked in]

    
    

    
  
hey it didn't break seamonkey either! :)

Thanks for cleaning up my mess.

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: