Closed
Bug 286286
Opened 20 years ago
Closed 20 years ago
Incorrect name check when adding a new classification
Categories
(Bugzilla :: Administration, task)
Tracking
()
RESOLVED
FIXED
Bugzilla 2.20
People
(Reporter: LpSolit, Assigned: LpSolit)
References
Details
Attachments
(1 file)
|
1.63 KB,
patch
|
jacob
:
review+
|
Details | Diff | Splinter Review |
When adding a new classification, a test checks if the name is already used or
not. It should also check that a name has been given! Actually, '' and '0' are
accepted but these classifications cannot be edited or deleted anymore.
Moreover, when editing an existing classification, the description is saved to
the DB *before* having done all tests, more precisely that a valid name has been
given. No modification to the DB should occur till all tests have run successfully.
Patch coming...
|
Assignee | |
Updated•20 years ago
|
Status: NEW → ASSIGNED
Target Milestone: --- → Bugzilla 2.20
|
||
Comment 2•20 years ago
|
||
Comment on attachment 177534 [details] [diff] [review]
patch, v1
Looks logical, doesn't break anything, fixes the stated problem :)
r=jake
Attachment #177534 -
Flags: review?(mkanat) → review+
|
|
Assignee | |
Updated•20 years ago
|
Flags: approval?
|
||
Updated•20 years ago
|
Flags: approval? → approval+
|
||
Comment 3•20 years ago
|
||
Checking in editclassifications.cgi;
/cvsroot/mozilla/webtools/bugzilla/editclassifications.cgi,v <--
editclassifications.cgi
new revision: 1.8; previous revision: 1.7
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in
before you can comment on or make changes to this bug.
Description
•