28634 - 2 warnings, xmltok.c (blamed in shrike Linux Cobbler)

Status: VERIFIED FIXED

(Core :: XML, defect, P3)

Description

[jupiter]

fix for build warnings in xmltok.c on lines 1278 & 1377

Comment 1

[jupiter]

Attachment: Fix for xmltok.c, lines 1278 & 1377

Comment 2

[jupiter]

patch attached

Comment 3

[John Bandhauer]

Reopening. The patch has not yet been applied. Marking this FIXED would normally 
result in no one ever looking at this bug again and thus never applying the 
patch. It is not FIXED until the tested code lands in the repository.

If there is some reason that the patch should not be applied then please note it 
here and mark the bug INVALID

Comment 4

[jupiter]

Thanks
I'm just getting started and have yet to figure out exactly how everything works.
I did post a note to mozilla.builds (as the 'Get Involved' page suggested), and was curious as to why nobody replied

Comment 5

[Alec Flett]

mmmm.... Linux Cobbler *drool*

Comment 6

[jupiter]

:P I feel foolish now.

Comment 7

[John G. Myers]

I think a better fix would be to make i unsigned.
Anyway, changing to xml component and assigning to module owner for review.

Comment 8

[Dawn Endico]

confirming bug to make sure owner notices this bug which has a 
patch to fix build warnings

Comment 9

[Nisheeth Ranjan]

slamm already checked in the warning fix.  Marking bug fixed.

Comment 10

[Chris Petersen]

Marking verified per last comments.