286380 - chrome.manifest not removed when an extension is uninstalled

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Robert Strong (they/them - no direct email)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050315 Firefox/1.0+
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b2) Gecko/20050315 Firefox/1.0+

It appears that the chrome.manifest file that was introduced by bug 278534 and
bug 283352 didn't include code to remove the chrome.manifest when an extension
is uninstalled (it is removed during an upgrade and then replaced with a new
one) which will then prevent the removal of the directory used by the
uninstalled directory.

Reproducible: Always

Steps to Reproduce:
1. Install, restart, uninstall an extension
Actual Results:  
The chrome.manifest remains

Expected Results:  
The chrome.manifest is removed and thereby allows the code in
nsExtensionManager.js to remove the no longer used directory.

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

This patch removes the chrome.manifest file when a theme or extension is
uninstalled. There are still issues with uninstalling themes as noted in the
patch due to bug 251026 which prevents a theme from being uninstalled when it
has a preview or icon in its jar.

Comment 2

[Robert Strong (they/them - no direct email)]

Attachment: patch (fixed indent)

Comment 3

[Benjamin Smedberg]

Comment on attachment 177597 [details] [diff] [review]
patch (fixed indent)

r=me, however please hold off landing this patch until Ben lands some
semi-significant extension manager reworking

Comment 4

[Robert Strong (they/them - no direct email)]

Not a problem. I suspect that the changes with Ben's patch from bug 286034 will
change the structure as well as flow significantly enough to make this patch as
well as the patch to bug 251026 and bug 252418 at best to not be need since the
functionality can be included in the rewrite and at worse require additional
rewrite of the code if these steps aren't taken into account in the flow.

Comment 5

[Przemyslaw Bialik]

Should this bug be set as a blocker for Bug 248298 ?

Comment 6

[Robert Strong (they/them - no direct email)]

I don't believe it is necessary to do so. I think we will know better after the
patch in bug 286034 is checked in and it does appear that it will fix bug 248298
and this one.

Comment 7

[Robert Strong (they/them - no direct email)]

Fixed by the checkin for bug 286034