String concatenation on postgres does not always work

RESOLVED FIXED in Bugzilla 2.20

Status

()

Bugzilla
Bugzilla-General
P1
normal
RESOLVED FIXED
13 years ago
13 years ago

People

(Reporter: Tomas Kopal, Assigned: Tomas Kopal)

Tracking

unspecified
Bugzilla 2.20
Bug Flags:
approval +
blocking2.20 +

Details

Attachments

(1 attachment)

V1
1.20 KB, patch
Max Kanat-Alexander
: review+
Details | Diff | Splinter Review
(Assignee)

Description

13 years ago
Postgres concat operator has relatively low priority, we need to put braces
around it to avoid problems when used in complex expressions. This problem does
not affect MySQL, as it does not use operator but function.
Patch will follow.
(Assignee)

Comment 1

13 years ago
Created attachment 177603 [details] [diff] [review]
V1

Added braces around string concatenation for postgres and generic ANSI.
Attachment #177603 - Flags: review?(mkanat)

Comment 2

13 years ago
Comment on attachment 177603 [details] [diff] [review]
V1

Oh funny, I was thinking about that when we wrote the CONCAT patch, too, I just
must have forgotten to mention it in review. :-)
Attachment #177603 - Flags: review?(mkanat) → review+

Updated

13 years ago
Status: NEW → ASSIGNED
Flags: blocking2.20?
Flags: approval?
Priority: -- → P1
Target Milestone: --- → Bugzilla 2.20
Flags: blocking2.20?
Flags: blocking2.20+
Flags: approval?
Flags: approval+

Comment 3

13 years ago
Checking in Bugzilla/DB.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB.pm,v  <--  DB.pm
new revision: 1.33; previous revision: 1.32
done
Checking in Bugzilla/DB/Pg.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla/DB/Pg.pm,v  <--  Pg.pm
new revision: 1.6; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.