286405 - "right" value of attribute crop is deprecated

Status: RESOLVED FIXED

(Firefox :: Page Info Window, defect)

Description

[Joel Nackman]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050315 Firefox/1.0+
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.8b2) Gecko/20050315 Firefox/1.0+

In pageInfo.xul, a deprecated value for the attribute crop is used.  Instead of
"right", the value should be "end".

Reproducible: Always

Steps to Reproduce:
1.  Look at the file


Actual Results:  
It uses a deprecated value.

Expected Results:  
It should use "end".

I will attach a patch I made, but I'm not sure if it's correct, it's the first
patch I've ever made.

Comment 1

[Joel Nackman]

Attachment: A patch

Comment 2

[Joel Nackman]

Comment on attachment 177605 [details] [diff] [review]
A patch

Just as I submitted the patch I realized that I had replaces all the rights in
the licence to ends by accident.

Sorry

Comment 3

[Joel Nackman]

Comment on attachment 177605 [details] [diff] [review]
A patch

>Index: pageInfo.xul
>===================================================================
>RCS file: /cvsroot/mozilla/browser/base/content/pageInfo.xul,v
>retrieving revision 1.20
>diff -u -r1.20 pageInfo.xul
>--- pageInfo.xul	5 Mar 2005 22:24:04 -0000	1.20
>+++ pageInfo.xul	16 Mar 2005 14:01:44 -0000
>@@ -101,7 +101,7 @@
> 
>       <!-- General page information -->
>       <vbox>
>-        <textbox class="header" readonly="true" crop="right" id="titletext"/>
>+        <textbox class="header" readonly="true" crop="end" id="titletext"/>
>         <grid>
>           <columns>
>             <column/>
>@@ -112,7 +112,7 @@
>             <row>
>               <label value="&generalURL;"/>
>               <separator/>
>-              <textbox readonly="true" crop="right" id="urltext"/>
>+              <textbox readonly="true" crop="end" id="urltext"/>
>             </row>
>             <row>
>               <separator class="thin"/>
>@@ -120,32 +120,32 @@
>             <row>
>               <label value="&generalType;"/>
>               <separator/>
>-              <textbox readonly="true" crop="right" id="typetext"/>
>+              <textbox readonly="true" crop="end" id="typetext"/>
>             </row>
>             <row>
>               <label value="&generalMode;"/>
>               <separator/>
>-              <textbox readonly="true" crop="right" id="modetext"/>
>+              <textbox readonly="true" crop="end" id="modetext"/>
>             </row>
>             <row>
>               <label value="&generalSource;"/>
>               <separator/>
>-              <textbox readonly="true" crop="right" id="sourcetext"/>
>+              <textbox readonly="true" crop="end" id="sourcetext"/>
>             </row>
>             <row>
>               <label value="&generalEncoding;"/>
>               <separator/>
>-              <textbox readonly="true" crop="right" id="encodingtext"/>
>+              <textbox readonly="true" crop="end" id="encodingtext"/>
>             </row>
>             <row>
>               <label value="&generalSize;"/>
>               <separator/>
>-              <textbox readonly="true" crop="right" id="sizetext"/>
>+              <textbox readonly="true" crop="end" id="sizetext"/>
>             </row>
>             <row>
>               <label value="&generalReferrer;"/>
>               <separator/>
>-              <textbox readonly="true" crop="right" id="refertext"/>
>+              <textbox readonly="true" crop="end" id="refertext"/>
>             </row>
>             <row>
>               <separator class="thin"/>
>@@ -153,12 +153,12 @@
>             <row>
>               <label value="&generalModified;"/>
>               <separator/>
>-              <textbox readonly="true" crop="right" id="modifiedtext"/>
>+              <textbox readonly="true" crop="end" id="modifiedtext"/>
>             </row>
>             <row>
>               <label value="&generalExpires;"/>
>               <separator/>
>-              <textbox readonly="true" crop="right" id="expirestext"/>
>+              <textbox readonly="true" crop="end" id="expirestext"/>
>             </row>
>           </rows>
>         </grid>
>@@ -203,12 +203,12 @@
>               <row>
>                 <label value="&formEncoding;"/>
>                 <separator/>
>-                <textbox readonly="true" crop="right" id="formenctype"/>
>+                <textbox readonly="true" crop="end" id="formenctype"/>
>               </row>
>               <row>
>                 <label value="&formTarget;"/>
>                 <separator/>
>-                <textbox readonly="true" crop="right" class="label" id="formtarget"/>
>+                <textbox readonly="true" crop="end" class="label" id="formtarget"/>
>               </row>
>             </rows>
>           </grid>
>@@ -282,52 +282,52 @@
>               <row>
>                 <label value="&mediaURL;"/>
>                 <separator/>
>-                <textbox readonly="true" crop="right" id="imageurltext"/>
>+                <textbox readonly="true" crop="end" id="imageurltext"/>
>               </row>
>               <row>
>                 <label value="&mediaTitle;"/>
>                 <separator/>
>-                <textbox readonly="true" crop="right" id="imagetitletext"/>
>+                <textbox readonly="true" crop="end" id="imagetitletext"/>
>               </row>
>               <row>
>                 <label value="&mediaAlt;"/>
>                 <separator/>
>-                <textbox readonly="true" crop="right" id="imagealttext"/>
>+                <textbox readonly="true" crop="end" id="imagealttext"/>
>               </row>
>               <row>
>                 <label value="&mediaLongdesc;"/>
>                 <separator/>
>-                <textbox readonly="true" crop="right" id="imagelongdesctext"/>
>+                <textbox readonly="true" crop="end" id="imagelongdesctext"/>
>               </row>
>               <row>
>                 <label value="&generalType;"/>
>                 <separator/>
>-                <textbox readonly="true" crop="right" id="imagetypetext"/>
>+                <textbox readonly="true" crop="end" id="imagetypetext"/>
>               </row>
>               <row>
>                 <label value="&generalSource;"/>
>                 <separator/>
>-                <textbox readonly="true" crop="right" id="imagesourcetext"/>
>+                <textbox readonly="true" crop="end" id="imagesourcetext"/>
>               </row>
>               <row>
>                 <label value="&generalSize;"/>
>                 <separator/>
>-                <textbox readonly="true" crop="right" id="imagesizetext"/>
>+                <textbox readonly="true" crop="end" id="imagesizetext"/>
>               </row>
>               <row>
>                 <label value="&generalExpires;"/>
>                 <separator/>
>-                <textbox readonly="true" crop="right" id="imageexpirestext"/>
>+                <textbox readonly="true" crop="end" id="imageexpirestext"/>
>               </row>
>               <row>
>                 <label value="&mediaDimensions;"/>
>                 <separator/>
>-                <textbox readonly="true" crop="right" id="imageSize"/>
>+                <textbox readonly="true" crop="end" id="imageSize"/>
>               </row>
>               <row id="physRow" collapsed="true">
>                 <label value="&mediaPhysDimensions;"/>
>                 <separator/>
>-                <textbox readonly="true" crop="right" id="physSize"/>
>+                <textbox readonly="true" crop="end" id="physSize"/>
>               </row>
>             </rows>
>           </grid>

Comment 4

[Andrew Schultz]

-# for the specific language governing rights and limitations under the
+# for the specific language governing ends and limitations under the

nope

-# Portions created by the Initial Developer are Copyright (C) 1998-1999
-# the Initial Developer. All Rights Reserved.
+# Portions created by the Initial Developer are Copyend (C) 1998-1999
+# the Initial Developer. All ends Reserved.

nope, nope.

==> page info (file seems to be shared btw FF and seamonkey)

for good reviewers, see
http://bonsai.mozilla.org/cvslog.cgi?file=mozilla/browser/base/content/pageInfo.xul

Comment 5

[Daniel Brooks [:db48x]]

Comment on attachment 177605 [details] [diff] [review]
A patch

yea, be careful about blind search-and-replace. Other than that, it looks good.

Comment 6

[Joel Nackman]

Attachment: A better patch.

If there are other files with the deprecated crop="right" attribute, would it
be appropriate to post patches for them here, or should a new bug be created
for each one?

Comment 7

[Daniel Brooks [:db48x]]

Comment on attachment 190737 [details] [diff] [review]
A better patch.

r=db48x

lets fix this bug, then you can file another one about the rest of the product,
or some subset of the rest of the product. I'll be happy to review that patch
as well.

Comment 8

[Joel Nackman]

What should I do now to get the patch checked in? Does this need super-review? 
I'm kind of unfamiliar with the process.  Sorry for asking so many questions.

Thanks,
Joel

Comment 9

[Daniel Brooks [:db48x]]

Comment on attachment 190737 [details] [diff] [review]
A better patch.

Yes, it needs sr. It also needs an approval since we're in the middle of a
freeze, so we'll request that at the same time.

Comment 10

[timeless]

Comment on attachment 190737 [details] [diff] [review]
A better patch.

mozilla/browser/base/content/pageInfo.xul	1.27

Comment 11

[Steffen Wilberg]

Moving the bug from Suite to Firefox since that's what it fixed.

Comment 12

[Steffen Wilberg]

Bugzilla still likes to kill flags when moving bugs across products.
The first patch had r-, the second one r+ by [e-mail].