286425 - Talkback FindFast needs to check for invalid time input and report an error (like with dates)

Status: RESOLVED WONTFIX

(mozilla.org :: Talkback Server & Webtool, task)

Description

[Stuart Strickland]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.6) Gecko/20050223 Firefox/1.0.1
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.6) Gecko/20050223 Firefox/1.0.1

From FastFind search page Quick Search box, Entering start and end dates, along
with a time specification, for search, causes an exception:

HTTP Status 500 -
type Exception report


Reproducible: Always

Steps to Reproduce:
http://talkback-public.mozilla.org/talkback/fastfind.jsp

This is what I entered:
Search by: Comments
"Begins With" "Tried to load" (minus the quote marks)
Vendor / Product / Platform: All
Build: -blank-
Start date: 03/15/2005 01:00
End date: 03/16/2005 11:59
Sort by: ID

Press Search
Actual Results:  
HTTP Status 500 -

type Exception report

message

description The server encountered an internal error () that prevented it from
fulfilling this request.

exception

org.apache.jasper.JasperException
	org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:358)
	org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:301)
	org.apache.jasper.servlet.JspServlet.service(JspServlet.java:248)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:856)

root cause

java.util.NoSuchElementException
	java.util.StringTokenizer.nextToken(StringTokenizer.java:259)
	tbsearch.TBInfo.createSearchQuery(TBInfo.java:182)
	tbsearch.TBInfoBean.processSearch(TBInfoBean.java:213)
	org.apache.jsp.fastfind_jsp._jspService(fastfind_jsp.java:271)
	org.apache.jasper.runtime.HttpJspBase.service(HttpJspBase.java:133)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:856)
	org.apache.jasper.servlet.JspServletWrapper.service(JspServletWrapper.java:311)
	org.apache.jasper.servlet.JspServlet.serviceJspFile(JspServlet.java:301)
	org.apache.jasper.servlet.JspServlet.service(JspServlet.java:248)
	javax.servlet.http.HttpServlet.service(HttpServlet.java:856)

note 
The full stack trace of the root cause is available in the Tomcat logs.
Apache Tomcat/5.0.19


Expected Results:  
1 crashes found where the Comment begins with 'tried to load' and the Crash Date
is between 03/15/2005 00:00:00 and 03/16/2005 23:59:59 and the sort is by ID. 

This appears to work OK when the times are left off.
It also seems to work OK when leading zeroes are left off the date, although it
displays a warning message while it searches:

Invalid Dates: 3/15/2005 and/or 3/16/2005
(they should be in mm/dd/yyyy format)

---
FWIW, this was reported as a side issue in Bug 271604 Comment #3
(https://bugzilla.mozilla.org/show_bug.cgi?id=271604#c3)

That one's status at this point is "Reopened", but no activity in >3 months.

---
Hardware info: Dell P3 933 MHz, 384 MB RAM, 56K dialup.
Software info: WinXP Pro SP2; Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US;
rv:1.7.6) Gecko/20050223 Firefox/1.0.1

Comment 1

[Jay Patel [:jay]]

There are a lot of conditions I haven't written code to check for, so make sure
to cover this one.  Until I fix it, the workaround is to put in valid dates (in
24 hr format) as suggested under the form field.

Comment 2

[Jay Patel [:jay]]

I already check for the date, but forgot to check for the time.   I will get
this fix into the next version of the Talkback query tools.

Comment 3

[Daniel Veditz [:dveditz]]

We have not used Talkback in years and it is not longer maintained. Closing bugs.