286492 - Silence assertion "found non euro modifier" in OS/2 debug builds

Status: VERIFIED FIXED

(Core :: Internationalization, defect)

Description

[Peter Weilbacher]

My locale is set to LANG=en_GB_EURO which is valid on OS/2 even with the all
capital "EURO". The code that I copied from Unix in bug 260427 assumed full
posix validity and a lower case "euro" and so gives an assertion in line 268 of
intl/locale/src/os2/nsOS2Locale.cpp.

Comment 1

[Peter Weilbacher]

Attachment: Replace strcmp with stricmp

Hmm, I don't think it really matters or is used anywhere else, so I just
silenced the assertion by using case insensitive compare. I hope this is
correct. Another possibility would be to compare against EURO... Btw, the OS/2
locales are listed on <http://borgendale.com/locale/locitem.htm>.

Comment 2

[Mike Kaply [:mkaply]]

I wonder why this assertion is there at all?

https://bugzilla.mozilla.org/show_bug.cgi?id=102516

Comment 3

[Peter Weilbacher]

I guess it is to warn of strange locales with invalid extra parts when debugging
this part. That kind of worked. Since I discovered this message in the debug
build some time ago I tried to find out more about OS/2 locales, if lower case
_euro is reqired. It doesn't seem to, but neither could I find info if upper
case _EURO is required, so stricmp is the best option. This and the other
asserts don't really hurt...

Comment 4

[Jungshik Shin]

Comment on attachment 177668 [details] [diff] [review]
Replace strcmp with stricmp

r=jshin

Comment 5

[Mike Kaply [:mkaply]]

fix checked in