286542 - in the html source of owners.html, each module owner and peer should be on a separate line

Status: VERIFIED FIXED

(Webtools Graveyard :: Despot, enhancement)

Description

[Steffen Wilberg]

It would be nice if the module owners and peers would be on a separate line each
in the html source of owners.html, to make diff and blame useful.
The display of the file in a browser would not be affected.

Comment 1

[Jonathan Watt [:jwatt]]

Some people are never happy. ;-) I agree, this would be better. Since I fixed
bug 245664 I'll take this one as well.

Comment 2

[Jonathan Watt [:jwatt]]

Attachment: patch

The Owners mailto is a URI, so I can't split it over multiple lines. However,
you should be able to tell which peer(s) have been added/removed more easily
with this patch.

Comment 3

[Jonathan Watt [:jwatt]]

Umm, oops. More haste less speed. That should be:

+                print OWNERS qq|
+        </td>

of course.

Comment 4

[Steffen Wilberg]

Thanks for taking this!

Some modules have more than one owner, e.g.
http://www.mozilla.org/owners.html#standalone-mail. Those should be on a
separate line as well. That's what I meant.

Comment 5

[Jonathan Watt [:jwatt]]

Attachment: alternative patch - puts owner names on separate lines

Ah, okay. How about this then?

Comment 6

[Myk Melez [:myk] [@mykmelez]]

Comment on attachment 177740 [details] [diff] [review]
alternative patch - puts owner names on separate lines

Escape characters aren't interpolated in single-quoted strings, so the join
string needs to be double-quoted.  Otherwise this looks good and works well.

Comment 7

[Jonathan Watt [:jwatt]]

Attachment: patch fixing quote marks

Okay, this should fix that.

Comment 8

[Jonathan Watt [:jwatt]]

Checked in. Marking fixed.

Checking in mozilla/webtools/despot/syncit.pl;
/cvsroot/mozilla/webtools/despot/syncit.pl,v  <--  syncit.pl
new revision: 1.31; previous revision: 1.30
done

Comment 9

[Steffen Wilberg]

Thanks again.