in the html source of owners.html, each module owner and peer should be on a separate line

VERIFIED FIXED

Status

Webtools Graveyard
Despot
--
enhancement
VERIFIED FIXED
13 years ago
a year ago

People

(Reporter: Steffen Wilberg, Assigned: jwatt)

Tracking

Details

(URL)

Attachments

(1 attachment, 2 obsolete attachments)

(Reporter)

Description

13 years ago
It would be nice if the module owners and peers would be on a separate line each
in the html source of owners.html, to make diff and blame useful.
The display of the file in a browser would not be affected.
(Reporter)

Updated

13 years ago
(Assignee)

Comment 1

13 years ago
Some people are never happy. ;-) I agree, this would be better. Since I fixed
bug 245664 I'll take this one as well.
Assignee: justdave → jonathan.watt
(Assignee)

Comment 2

13 years ago
Created attachment 177735 [details] [diff] [review]
patch

The Owners mailto is a URI, so I can't split it over multiple lines. However,
you should be able to tell which peer(s) have been added/removed more easily
with this patch.
Attachment #177735 - Flags: review?(myk)
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
(Assignee)

Comment 3

13 years ago
Umm, oops. More haste less speed. That should be:

+                print OWNERS qq|
+        </td>

of course.
(Reporter)

Comment 4

13 years ago
Thanks for taking this!

Some modules have more than one owner, e.g.
http://www.mozilla.org/owners.html#standalone-mail. Those should be on a
separate line as well. That's what I meant.
(Assignee)

Comment 5

13 years ago
Created attachment 177740 [details] [diff] [review]
alternative patch - puts owner names on separate lines

Ah, okay. How about this then?
Attachment #177740 - Flags: review?(myk)
Comment on attachment 177740 [details] [diff] [review]
alternative patch - puts owner names on separate lines

Escape characters aren't interpolated in single-quoted strings, so the join
string needs to be double-quoted.  Otherwise this looks good and works well.
Attachment #177740 - Flags: review?(myk) → review-
Attachment #177735 - Flags: review?(myk)
(Assignee)

Comment 7

13 years ago
Created attachment 177779 [details] [diff] [review]
patch fixing quote marks

Okay, this should fix that.
Attachment #177735 - Attachment is obsolete: true
Attachment #177740 - Attachment is obsolete: true
Attachment #177779 - Flags: review?(myk)
Attachment #177779 - Flags: review?(myk) → review+
(Assignee)

Comment 8

13 years ago
Checked in. Marking fixed.

Checking in mozilla/webtools/despot/syncit.pl;
/cvsroot/mozilla/webtools/despot/syncit.pl,v  <--  syncit.pl
new revision: 1.31; previous revision: 1.30
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Reporter)

Comment 9

13 years ago
Thanks again.
Status: RESOLVED → VERIFIED
Product: Webtools → Webtools Graveyard
You need to log in before you can comment on or make changes to this bug.