286555 - When selecting a folder in the folder list, the folder immediately below the one clicked is selected.

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Paul Smedley]

User-Agent:       Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8b2) Gecko/20050316 Firefox/1.0+
Build Identifier: Mozilla/5.0 (OS/2; U; Warp 4.5; en-US; rv:1.8b2) Gecko/20050316 Firefox/1.0+

When clicking for example the Inbox, the folder below Inbox, ie drafts is selected.

Resizing the Thunderbird window solves this problem until the next reload.

This behaved as expected in Thunderbird 1.0 and has been broken since approx
January on OS/2.

Reproducible: Always

Steps to Reproduce:
1. Click Inbox, 
2.
3.

Actual Results:  
Drafts will be selected.

Expected Results:  
Selected Inbox.

Comment 1

[Peter Weilbacher]

Yes, this was confirmed by several people in the newsgroup.

Comment 2

[Mike Kaply [:mkaply]]

Visually, I can see why this is happening. The column headers in the folder
window appear and then disappear, but the window isn't getting its new size
properly.

Comment 3

[Mike Kaply [:mkaply]]

OK, I got a thunderbird build from 12/15/2004 and it happened there...

Comment 4

[Steve Wardell]

Reporter: I believe this item was fixed a while back as I experienced it as well
but I'm not sure the bug # it got fixed in. If you still experience this with
current nightly builds, please re-open.

Comment 5

[Paul Smedley]

Yes this bug is still present in the OS/2 nightly builds.

Comment 6

[Mike Kaply [:mkaply]]

*** Bug 308234 has been marked as a duplicate of this bug. ***

Comment 7

[Rich Walsh]

In Bug #308234, Peter provided a workaround that forced recalculation of the
window size every time a folder was selected.  Here's a minor improvement which
forces the recalculation only once, when the window is first created (the
affected JS function is delayedOnLoadMessenger()):

Index: mozilla/mail/base/content/msgMail3PaneWindow.js
===================================================================
RCS file: /cvsroot/mozilla/mail/base/content/msgMail3PaneWindow.js,v
retrieving revision 1.72
diff -u -r1.72 msgMail3PaneWindow.js
--- mozilla/mail/base/content/msgMail3PaneWindow.js     14 Sep 2005 03:05:59
-0000      1.72
+++ mozilla/mail/base/content/msgMail3PaneWindow.js     22 Sep 2005 02:38:41 -0000
@@ -845,6 +845,9 @@

   var toolbarset = document.getElementById('customToolbars');
   toolbox.toolbarset = toolbarset;
+
+  this.resizeBy(0,-1);
+  this.resizeBy(0,+1);
 }

 function OnUnloadMessenger()

Comment 8

[Mike Kaply [:mkaply]]

I have this narrowed down to between Oct 11 and Oct 15 - I'm still working.

My gut says it is this bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=285136

Apply bug 221824 "themes should be RTL compatible" to thunderbird

Does this happen in Seamonkey and thunderbird or just thunderbird?

Comment 9

[Scott MacGregor]

Mike, this bug was filed in March of 2005, the RTL stuff just landed a few days
ago. I'm confused :)

Comment 10

[Mike Kaply [:mkaply]]

Sorry, I'm the confused one :)

I used bad dates.

Here's my window right now:

http://bonsai.mozilla.org/cvsquery.cgi?treeid=default&module=all&branch=HEAD&branchtype=match&dir=&file=&filetype=match&who=&whotype=match&sortby=Date&hours=2&date=explicit&mindate=2004-10-11+00%3A00%3A00&maxdate=2004-10-13+00%3A00%3A00&cvsroot=%2Fcvsroot

I'll have it narrowed down one more day by tomorrow.

Comment 11

[Mike Kaply [:mkaply]]

This was caused by:

https://bugzilla.mozilla.org/show_bug.cgi?id=238493

Need to (re)implement widget change caching

So my guess is there is some platform specific change needed...

Comment 12

[Mike Kaply [:mkaply]]

Attachment: Fix for problem

mBounds was not getting set in the resize case so we weren't properly caching
postition/size.

Comment 13

[Peter Weilbacher]

Comment on attachment 200091 [details] [diff] [review]
Fix for problem

If this works, should you then not get rid of the else branch twenty lines
further down which sets mBounds again?

Comment 14

[Mike Kaply [:mkaply]]

Attachment: Better patch per peter

Comment 15

[Peter Weilbacher]

Comment on attachment 200215 [details] [diff] [review]
Better patch per peter

Don't have time to verify in Thunderbird at the moment, but it seems logical
and doesn't break SeaMonkey or Firefox. :-)

Comment 16

[Mike Kaply [:mkaply]]

Fix checked in. Woohoo!