286567 - Checksetup.pl fails when BugMail.pm is changed to use SMTP

Status: RESOLVED DUPLICATE of bug 280911

(Bugzilla :: Installation & Upgrading, defect)

Description

[Stephen Klein]

User-Agent:       Mozilla/4.0 (compatible; MSIE 6.0; Windows NT 5.1; SV1; .NET CLR 1.1.4322)
Build Identifier: 

Installing Bugzilla on Win2k server.  Everything works fine until customizing 
BugMail.pm to use SMTP instead of SendMail.  I followed the instructions 
provided in the Bugzilla Guide.  My code looks like this, per the 
instructions...

-----------------------------------------
    if ($enableSendMail == 1) {
	use Net::SMTP;
	my $smtp_server = 'mailserverFQDN';
	my $smtp = Net::SMTP->new($smtp_server) ||
	   die 'Cannot connect to server \'$smtp_server\";

	$smtp->mail('[e-mail]');
	$smtp->to($person);
	$smtp->data();
	$smtp->datasend($msg);
	$smtp->dataend();
	$smtp->quit;
    }
-----------------------------------------
I have changed the actual file to reflect our mailserver's FQDN and the e-mail 
address of the person that will be managing Bugzilla once it's running.
When I save the changes to BugMail.pm and then try to run Checksetup.pl, I 
recieve the following error...

-----------------------------------------
Precompiling templates ...
Bareword found where operator expected at Bugzilla/BugMail.pm line 877, 
near "$smtp->mail('sklein"
  (Might be a runaway multi-line '' string starting on line 875)
        (Missing operator before sklein?)
Array found where operator expected at Bugzilla/BugMail.pm line 877, at end of 
line
Bad name after com' at Bugzilla/BugMail.pm line 877.
Compilation failed in require at globals.pl line 36.
BEGIN failed--compilation aborted at globals.pl line 36.
Compilation failed in require at D:\bugzillafiles\checksetup.pl line 1422.
-----------------------------------------

Any help you can provide would be appreciated.
Thanks again!

Reproducible: Always

Steps to Reproduce:
1.  Install Win2k w/ SP4 and IIS 5.1
2.  Install ActivePerl 5.8.2.808 for Win32
3.  Install MySQL 4.1.10a for Win32
4.  Follow instructions provided by Bugzilla for installation and customization
5.  Skip section 2.2.2.3 "Permit attachments table to grow beyond 4GB"
6.  Follow instructions in section 2.4.1.3 "Code changes required to run on 
Win32"
7.  Re-run Checksetup.pl after making changes to BugMail.pm
8.  Above error received at command line.

Actual Results:  
Received error at command line.

Expected Results:  
Finished Checksetup.pl and updated with proper settings in BugMail.pm

Comment 1

[Max Kanat-Alexander]

That's a bug in your modifications. Look at your die.

Comment 2

[Stephen Klein]

I looked at the code on the line that begins with the die.  I noticed that the 
instructions that were printed out looked a little different than the ones on 
the website.  A word processor must have changed the '' to " automatically.
So, I changed the die line to read like this...

die 'Cannot connect to server \'$smtp_server\'';

And after that, I received another error when I ran Checksetup.pl.  It looked 
like this...

Precompiling templates ...
Global symbol "$person" requires explicit package name at Bugzilla/BugMail.pm 
line 876.
Compilation failed in require at globals.pl line 36.
BEGIN failed--compilation aborted at globals.pl line 36.
Compilation failed in require at D:\bugzillafiles\checksetup.pl line 1422.

Comment 3

[Marc Schumann [:Wurblzap]]

That makes this a dupe of bug 280911, right?

Comment 4

[Max Kanat-Alexander]

Yep.

*** This bug has been marked as a duplicate of 280911 ***