286608 - netwerk/socket/base/Makefile.in disables xpt generation on windows for no obvious reason

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

70 ifeq ($(OS_ARCH),WINNT)
 71 NO_GEN_XPT=1
 72 endif

this has been there since revision 1.1 of makefile.win (and got merged to
Makefile.in at some point, when the nmake-based build system was being removed)
(http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/netwerk/socket/base/makefile.win)

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

Checking in netwerk/socket/base/Makefile.in;
/cvsroot/mozilla/netwerk/socket/base/Makefile.in,v  <--  Makefile.in
new revision: 1.19; previous revision: 1.18
done

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Comment on attachment 177753 [details] [diff] [review]
patch

this just makes it so we generate xpt files on windows (we already do on other
platforms). this is needed to make bug 286612 useful on windows.

Comment 4

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 177753 [details] [diff] [review]
patch

1.7.6 matches aviary1.0.2.  too late for this set.  you'll want to request
1.7.7 approval once those flags exist.

Comment 5

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 177753 [details] [diff] [review]
patch

We're not taking changes for Aviary 1.0.x other than security fixes and
regressions along the Aviary 1.0.x series (i.e., regressions from security
fixes).