286612 - netwerk/socket/base interfaces should be scriptable

Status: RESOLVED FIXED

(Core :: Networking, defect, P1)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

currently, basically all of them are noscript. nsISocketProvider has to, since
it deals with PRNetAddresses, but the rest don't.

Also, various files in that dir are not part of the build.

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: patch

not sure whether the nsISOCKSSocketInfo change is worth it, since it does not
make the interface very scriptable.  Also, the nsISocketProviderService change
isn't all that helpful. I figured they didn't hurt though.

Comment 2

[Darin Fisher]

Comment on attachment 177754 [details] [diff] [review]
patch

r+sr=darin

Comment 3

[Christian :Biesinger (don't email me, ping me on IRC)]

Removing nsISOCKS4SocketProvider.idl;
/cvsroot/mozilla/netwerk/socket/base/nsISOCKS4SocketProvider.idl,v  <-- 
nsISOCKS4SocketProvider.idl
new revision: delete; previous revision: 1.2
done
Checking in nsISOCKSSocketInfo.idl;
/cvsroot/mozilla/netwerk/socket/base/nsISOCKSSocketInfo.idl,v  <-- 
nsISOCKSSocketInfo.idl
new revision: 1.5; previous revision: 1.4
done
Removing nsISOCKSSocketProvider.idl;
/cvsroot/mozilla/netwerk/socket/base/nsISOCKSSocketProvider.idl,v  <-- 
nsISOCKSSocketProvider.idl
new revision: delete; previous revision: 1.4
done
Checking in nsISocketProvider.idl;
/cvsroot/mozilla/netwerk/socket/base/nsISocketProvider.idl,v  <-- 
nsISocketProvider.idl
new revision: 1.13; previous revision: 1.12
done
Checking in nsISocketProviderService.idl;
/cvsroot/mozilla/netwerk/socket/base/nsISocketProviderService.idl,v  <-- 
nsISocketProviderService.idl
new revision: 1.8; previous revision: 1.7
done
Checking in nsITransportSecurityInfo.idl;
/cvsroot/mozilla/netwerk/socket/base/nsITransportSecurityInfo.idl,v  <-- 
nsITransportSecurityInfo.idl
new revision: 1.6; previous revision: 1.5
done
Removing nsSOCKS4SocketProvider.cpp;
/cvsroot/mozilla/netwerk/socket/base/nsSOCKS4SocketProvider.cpp,v  <-- 
nsSOCKS4SocketProvider.cpp
new revision: delete; previous revision: 1.5
done

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

Attachment: branch patch

[I can't figure out which combination of flags I should request if I want this
for both the 1.7 branch and the aviary branch. please grant whichever
combination is appropriate]

same patch, for the 1.7 branch. does not contain file removals, nor the rename
of the native type in nsISocketProvider.idl

since this just changes some interfaces from [noscript] to [scriptable], this
should be quite low-risk.

Comment 5

[Christopher Aillon (sabbatical, not receiving bugmail)]

Comment on attachment 177914 [details] [diff] [review]
branch patch

too late for 1.0.2 and 1.7.6.

Comment 6

[David Baron :dbaron: (⌚️UTC-4, no longer working on Mozilla)]

Comment on attachment 177914 [details] [diff] [review]
branch patch

We're not taking changes for Aviary 1.0.x other than security fixes and
regressions along the Aviary 1.0.x series (i.e., regressions from security
fixes).