Closed Bug 286612 Opened 20 years ago Closed 20 years ago

netwerk/socket/base interfaces should be scriptable

Categories

(Core :: Networking, defect, P1)

defect

Tracking

()

RESOLVED FIXED
mozilla1.8beta2

People

(Reporter: Biesinger, Assigned: Biesinger)

Details

Attachments

(2 files)

currently, basically all of them are noscript. nsISocketProvider has to, since
it deals with PRNetAddresses, but the rest don't.

Also, various files in that dir are not part of the build.
Attached patch patchSplinter Review
not sure whether the nsISOCKSSocketInfo change is worth it, since it does not
make the interface very scriptable.  Also, the nsISocketProviderService change
isn't all that helpful. I figured they didn't hurt though.
Attachment #177754 - Flags: review?(darin)
Status: NEW → ASSIGNED
Priority: -- → P1
Target Milestone: --- → mozilla1.8beta2
Comment on attachment 177754 [details] [diff] [review]
patch

r+sr=darin
Attachment #177754 - Flags: superreview+
Attachment #177754 - Flags: review?(darin)
Attachment #177754 - Flags: review+
Removing nsISOCKS4SocketProvider.idl;
/cvsroot/mozilla/netwerk/socket/base/nsISOCKS4SocketProvider.idl,v  <-- 
nsISOCKS4SocketProvider.idl
new revision: delete; previous revision: 1.2
done
Checking in nsISOCKSSocketInfo.idl;
/cvsroot/mozilla/netwerk/socket/base/nsISOCKSSocketInfo.idl,v  <-- 
nsISOCKSSocketInfo.idl
new revision: 1.5; previous revision: 1.4
done
Removing nsISOCKSSocketProvider.idl;
/cvsroot/mozilla/netwerk/socket/base/nsISOCKSSocketProvider.idl,v  <-- 
nsISOCKSSocketProvider.idl
new revision: delete; previous revision: 1.4
done
Checking in nsISocketProvider.idl;
/cvsroot/mozilla/netwerk/socket/base/nsISocketProvider.idl,v  <-- 
nsISocketProvider.idl
new revision: 1.13; previous revision: 1.12
done
Checking in nsISocketProviderService.idl;
/cvsroot/mozilla/netwerk/socket/base/nsISocketProviderService.idl,v  <-- 
nsISocketProviderService.idl
new revision: 1.8; previous revision: 1.7
done
Checking in nsITransportSecurityInfo.idl;
/cvsroot/mozilla/netwerk/socket/base/nsITransportSecurityInfo.idl,v  <-- 
nsITransportSecurityInfo.idl
new revision: 1.6; previous revision: 1.5
done
Removing nsSOCKS4SocketProvider.cpp;
/cvsroot/mozilla/netwerk/socket/base/nsSOCKS4SocketProvider.cpp,v  <-- 
nsSOCKS4SocketProvider.cpp
new revision: delete; previous revision: 1.5
done
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Attached patch branch patchSplinter Review
[I can't figure out which combination of flags I should request if I want this
for both the 1.7 branch and the aviary branch. please grant whichever
combination is appropriate]

same patch, for the 1.7 branch. does not contain file removals, nor the rename
of the native type in nsISocketProvider.idl

since this just changes some interfaces from [noscript] to [scriptable], this
should be quite low-risk.
Attachment #177914 - Flags: approval1.7.6?
Attachment #177914 - Flags: approval-aviary1.0.3?
Attachment #177914 - Flags: approval-aviary1.0.2?
Comment on attachment 177914 [details] [diff] [review]
branch patch

too late for 1.0.2 and 1.7.6.
Attachment #177914 - Flags: approval1.7.6?
Attachment #177914 - Flags: approval1.7.6-
Attachment #177914 - Flags: approval-aviary1.0.2?
Attachment #177914 - Flags: approval-aviary1.0.2-
Comment on attachment 177914 [details] [diff] [review]
branch patch

We're not taking changes for Aviary 1.0.x other than security fixes and
regressions along the Aviary 1.0.x series (i.e., regressions from security
fixes).
Attachment #177914 - Flags: approval1.7.7?
Attachment #177914 - Flags: approval1.7.7-
Attachment #177914 - Flags: approval-aviary1.0.3?
Attachment #177914 - Flags: approval-aviary1.0.3-
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: