"Destination Directory" of "Setup Style" is broken on l10n build

RESOLVED FIXED

Status

P1
normal
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: masayuki, Assigned: masayuki)

Tracking

({fixed1.7.7, intl})

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments, 1 obsolete attachment)

On the installer, the "Destination Directory" label of "Setup Style" is broken
on l10n build.
Created attachment 177816 [details]
screenshot

I'll create the patch.
Flags: blocking1.8b2?
Flags: blocking1.7.6?
Created attachment 177836 [details] [diff] [review]
Patch rv1.0(for Trunk)
Attachment #177836 - Flags: superreview?(dveditz)
Attachment #177836 - Flags: review?(dveditz)
Status: NEW → ASSIGNED
Attachment #177836 - Flags: superreview?(dveditz)
Attachment #177836 - Flags: superreview+
Attachment #177836 - Flags: review?(dveditz)
Attachment #177836 - Flags: review?(benjamin)
Priority: -- → P1

Comment 3

14 years ago
Comment on attachment 177836 [details] [diff] [review]
Patch rv1.0(for Trunk)

If bsmedberg is ok with this a=chofmann.  final en-us builds for 1.7.6 have
been created but ja build could pick this up.
Attachment #177836 - Flags: approval1.7.6? → approval1.7.6+
Thank you Chris.
Benjamin, please hurry up.
Oops...

We need another patch for 1.7 branch.
Because 1.7 branch has another problem.
by bug 47762, the proc message window's problem is fixed on only trunk.
Attachment #177836 - Attachment description: Patch rv1.0 → Patch rv1.0(for Trunk)
Created attachment 178115 [details] [diff] [review]
Patch rv1.0(for 1.7Branch)
Attachment #178115 - Flags: superreview?(dveditz)
Attachment #178115 - Flags: review?(benjamin)
Attachment #178115 - Flags: approval1.7.6?
Comment on attachment 178115 [details] [diff] [review]
Patch rv1.0(for 1.7Branch)

sr=dveditz
Attachment #178115 - Flags: superreview?(dveditz) → superreview+

Updated

14 years ago
Attachment #178115 - Flags: review?(benjamin) → review+
Comment on attachment 178115 [details] [diff] [review]
Patch rv1.0(for 1.7Branch)

I re-request the approval1.7.7.
Mozilla 1.7.6-Ja will release without this patch.
Attachment #178115 - Flags: approval1.7.6? → approval1.7.7?
Flags: blocking1.7.6?
Target Milestone: --- → mozilla1.8beta2

Updated

14 years ago
Attachment #177836 - Flags: review?(benjamin)
Comment on attachment 177836 [details] [diff] [review]
Patch rv1.0(for Trunk)

Benjamin:

Why you canceled?
I want your review for this patch, too.
This differs from attachment 178115 [details] [diff] [review].
Attachment #177836 - Flags: review?(benjamin)

Comment 10

14 years ago
Comment on attachment 178115 [details] [diff] [review]
Patch rv1.0(for 1.7Branch)

a=chofmann for the branch
Attachment #178115 - Flags: approval1.7.7? → approval1.7.7+
Comment on attachment 178115 [details] [diff] [review]
Patch rv1.0(for 1.7Branch)

checked-in to 1.7branch only.
Attachment #178115 - Attachment is obsolete: true

Updated

14 years ago
Flags: blocking-seamonkey1.0a?

Updated

14 years ago
Attachment #177836 - Flags: review?(benjamin) → review+
checked-in to trunk.
Thanks,

-> FIXED
Status: ASSIGNED → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
Flags: blocking-seamonkey1.0a?

Updated

14 years ago
Target Milestone: mozilla1.8beta2 → ---
Keywords: fixed1.7.7
You need to log in before you can comment on or make changes to this bug.