Closed Bug 286670 Opened 16 years ago Closed 16 years ago

"Destination Directory" of "Setup Style" is broken on l10n build

Categories

(SeaMonkey :: Installer, defect, P1)

x86
Windows 98
defect

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: masayuki, Assigned: masayuki)

Details

(Keywords: fixed1.7.7, intl)

Attachments

(2 files, 1 obsolete file)

On the installer, the "Destination Directory" label of "Setup Style" is broken
on l10n build.
Flags: blocking1.8b2?
Flags: blocking1.7.6?
Attachment #177836 - Flags: superreview?(dveditz)
Attachment #177836 - Flags: superreview+
Attachment #177836 - Flags: review?(dveditz)
Attachment #177836 - Flags: review?(benjamin)
Comment on attachment 177836 [details] [diff] [review]
Patch rv1.0(for Trunk)

If bsmedberg is ok with this a=chofmann.  final en-us builds for 1.7.6 have
been created but ja build could pick this up.
Attachment #177836 - Flags: approval1.7.6? → approval1.7.6+
Thank you Chris.
Benjamin, please hurry up.
Oops...

We need another patch for 1.7 branch.
Because 1.7 branch has another problem.
by bug 47762, the proc message window's problem is fixed on only trunk.
Attachment #177836 - Attachment description: Patch rv1.0 → Patch rv1.0(for Trunk)
Attached patch Patch rv1.0(for 1.7Branch) (obsolete) — Splinter Review
Attachment #178115 - Flags: superreview?(dveditz)
Attachment #178115 - Flags: review?(benjamin)
Attachment #178115 - Flags: approval1.7.6?
Comment on attachment 178115 [details] [diff] [review]
Patch rv1.0(for 1.7Branch)

sr=dveditz
Attachment #178115 - Flags: superreview?(dveditz) → superreview+
Attachment #178115 - Flags: review?(benjamin) → review+
Comment on attachment 178115 [details] [diff] [review]
Patch rv1.0(for 1.7Branch)

I re-request the approval1.7.7.
Mozilla 1.7.6-Ja will release without this patch.
Attachment #178115 - Flags: approval1.7.6? → approval1.7.7?
Flags: blocking1.7.6?
Target Milestone: --- → mozilla1.8beta2
Attachment #177836 - Flags: review?(benjamin)
Comment on attachment 177836 [details] [diff] [review]
Patch rv1.0(for Trunk)

Benjamin:

Why you canceled?
I want your review for this patch, too.
This differs from attachment 178115 [details] [diff] [review].
Attachment #177836 - Flags: review?(benjamin)
Comment on attachment 178115 [details] [diff] [review]
Patch rv1.0(for 1.7Branch)

a=chofmann for the branch
Attachment #178115 - Flags: approval1.7.7? → approval1.7.7+
Comment on attachment 178115 [details] [diff] [review]
Patch rv1.0(for 1.7Branch)

checked-in to 1.7branch only.
Attachment #178115 - Attachment is obsolete: true
Flags: blocking-seamonkey1.0a?
Attachment #177836 - Flags: review?(benjamin) → review+
checked-in to trunk.
Thanks,

-> FIXED
Status: ASSIGNED → RESOLVED
Closed: 16 years ago
Resolution: --- → FIXED
Flags: blocking-seamonkey1.0a?
Target Milestone: mozilla1.8beta2 → ---
Keywords: fixed1.7.7
You need to log in before you can comment on or make changes to this bug.