286727 - DecodeStructParticle doesn't understand nsSupportsArray::RemoveElement

Status: RESOLVED INVALID

(Core Graveyard :: Web Services, defect)

Description

[timeless]

http://lxr.mozilla.org/seamonkey/source/xpcom/ds/nsVoidArray.h#116
116   PRBool RemoveElementsAt(PRInt32 aIndex, PRInt32 aCount);
117   PRBool RemoveElementAt(PRInt32 aIndex) { return RemoveElementsAt(aIndex,1); }

2260                 rc = all->RemoveElementAt(i);
2262                 if (NS_FAILED(rc))
2263                   return rc;

Comment 1

[Boris Zbarsky [:bzbarsky]]

Doron, this is pretty major (this function will bail out on _success_, not
failure).  Got time to fix?

Comment 2

[Doron Rosenberg (IBM)]

So the problem is the method returns a PRBool but the code is assuming NS_*, right? 

Comment 3

[Boris Zbarsky [:bzbarsky]]

Yes.  The return value on success will be 1, which will test true for NS_FAILED
and false for NS_SUCCEEDED (since NS_OK == 0).

Comment 4

[Christian :Biesinger (don't email me, ping me on IRC)]

fwiw 0 and 1 are both success codes, failure codes require the MSB bit set.