Closed Bug 286806 Opened 20 years ago Closed 20 years ago

Package mailnews chrome files directly from mozilla\mail

Categories

(Thunderbird :: Mail Window Front End, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED
Thunderbird1.1

People

(Reporter: mscott, Assigned: mscott)

Details

Attachments

(1 file)

Apparently jar.mn files now have this new trick where you can package a chrome file from a different directory. i.e. in mozilla\mail\base\jar.mn i can have a line like: content/messenger/subscribe.js (/mailnews/base/resources/content/subscribe.js) which will reach down into the mailnews direcory and snag subscribe.js from there. This means several things: 1) You could now modify shared chrome files that live in mailnews but still just rebuild mozilla\mail without having to rebuild both directories like you currently have today. 2) I can get rid of all the '+' lines in mozilla\mail's jar.mn files that force us to overwrite existing files. 3) We can stop running the mozilla\mailnews jar manifest files
FYI, Neil pointed this trick out to me a while ago.
Status: NEW → ASSIGNED
Target Milestone: --- → Thunderbird1.1
Attached patch the fixSplinter Review
asking David for sr, mostly so he's aware that he won't have to build chrome from two directories anymore. This gets rid of all the force overides (+) in the manifest files. mozilla\mail now looks into mailnews to grab any shared chrome files. Ifdefed the jar manifest in mozilla\mailnws to do nothing for Thunderbird.
Attachment #177932 - Flags: superreview?(bienvenu)
Attachment #177932 - Flags: superreview?(bienvenu) → superreview+
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: