Closed Bug 28683 Opened 25 years ago Closed 25 years ago

Opening a remote location via Open Location doesn't work if loading into Composer

Categories

(Core :: DOM: Editor, defect, P3)

defect

Tracking

()

VERIFIED FIXED

People

(Reporter: cmanske, Assigned: cmanske)

References

()

Details

(Keywords: regression, Whiteboard: [PDT+]fix in hand 2/24)

Attachments

(1 file)

From either a brower or composer window:
Use the menu command File | Open Web Location to bring up a dialog to load
remote pages. Enter a valid http: URL (e.g.: 
http://blues/users/bijals/publish/composer/composerbor2.htm)
and you get an error message.
Note that if window with file already exists, it does switch to that window.
Or if the URL is first loaded in a browser window, and File | Edit Page is 
used, it loads correctly.
We are using the exact same code as the browser to call the Open Web Location
dialog, by the way.
Simon: Feel free to investigate this if you have time!
Does anyone feel this is a beta1 issue? I bet the fix is simple.
I've seen this on Mac today as well; this is a regression from last week.
Severity: normal → blocker
Keywords: regression
OS: Windows NT → All
Hardware: PC → All
add keyword beta1
Charley--any ideas what caused this regression?
Keywords: beta1
No. Will investigate more thoroughly if judged to be PDT+
Target Milestone: M14
Putting on PDT+ radar for beta1.
Whiteboard: [PDT+]
Checked in 2/23
Status: NEW → RESOLVED
Closed: 25 years ago
Resolution: --- → FIXED
In 2/23/00-08 early morning builds, I still get an error dialog.  However, I can 
cut/paste now.
still a problem in 2/24 build....

I try loading any URL on the net into the composer via Open Web Location
and it doesn't work..I get an error panel

in browser it works..
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
I thought I was going crazy -- it worked when I tested it.
What is happening now is that loading a URL via this dialog works into either 
a Browser and Composer works, but only if the starting window is a Browser.
If you are in a Composer window and use "Open Location", it FAILS to load
into either a Browser or Composer.
So this is really a different issue than the one originally fixed.
I bet it's a "permission to load window is refused" issue.

Status: REOPENED → ASSIGNED
Ok, I have a very simple fix now (it was tough to diagnose!)
Simple set a checkbox value to "false" when loading from editor -- this 
checkbox was being hidden, but the initialized checked state was "true",
which made it act like we were loading from a non-existing browser window,
thus the JS exception.
Whiteboard: [PDT+] → [PDT+]2/24
Whiteboard: [PDT+]2/24 → [PDT+]fix in hand 2/24
cc michael lowe, who wrote that dialog
Attached file Diff for bug fix
i've tested charlie's fix on the mac - works fine.
Checked in late 2/24
Status: ASSIGNED → RESOLVED
Closed: 25 years ago25 years ago
Resolution: --- → FIXED
verified in 2/25 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: