Opening a remote location via Open Location doesn't work if loading into Composer

VERIFIED FIXED in M14

Status

()

Core
Editor
P3
blocker
VERIFIED FIXED
18 years ago
17 years ago

People

(Reporter: Charles Manske, Assigned: Charles Manske)

Tracking

({regression})

Trunk
regression
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

(Whiteboard: [PDT+]fix in hand 2/24, URL)

Attachments

(1 attachment)

(Assignee)

Description

18 years ago
From either a brower or composer window:
Use the menu command File | Open Web Location to bring up a dialog to load
remote pages. Enter a valid http: URL (e.g.: 
http://blues/users/bijals/publish/composer/composerbor2.htm)
and you get an error message.
Note that if window with file already exists, it does switch to that window.
Or if the URL is first loaded in a browser window, and File | Edit Page is 
used, it loads correctly.
We are using the exact same code as the browser to call the Open Web Location
dialog, by the way.
Simon: Feel free to investigate this if you have time!
Does anyone feel this is a beta1 issue? I bet the fix is simple.

Comment 1

18 years ago
I've seen this on Mac today as well; this is a regression from last week.
Severity: normal → blocker
Keywords: regression
OS: Windows NT → All
Hardware: PC → All

Comment 2

18 years ago
add keyword beta1
Charley--any ideas what caused this regression?
Keywords: beta1
(Assignee)

Comment 3

18 years ago
No. Will investigate more thoroughly if judged to be PDT+

Updated

18 years ago
Target Milestone: M14

Comment 4

18 years ago
Putting on PDT+ radar for beta1.
Whiteboard: [PDT+]
(Assignee)

Comment 5

18 years ago
Checked in 2/23
Status: NEW → RESOLVED
Last Resolved: 18 years ago
Resolution: --- → FIXED

Comment 6

18 years ago
In 2/23/00-08 early morning builds, I still get an error dialog.  However, I can 
cut/paste now.

Comment 7

18 years ago
still a problem in 2/24 build....

I try loading any URL on the net into the composer via Open Web Location
and it doesn't work..I get an error panel

in browser it works..
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
(Assignee)

Comment 8

18 years ago
I thought I was going crazy -- it worked when I tested it.
What is happening now is that loading a URL via this dialog works into either 
a Browser and Composer works, but only if the starting window is a Browser.
If you are in a Composer window and use "Open Location", it FAILS to load
into either a Browser or Composer.
So this is really a different issue than the one originally fixed.
I bet it's a "permission to load window is refused" issue.

Status: REOPENED → ASSIGNED
(Assignee)

Comment 9

18 years ago
Ok, I have a very simple fix now (it was tough to diagnose!)
Simple set a checkbox value to "false" when loading from editor -- this 
checkbox was being hidden, but the initialized checked state was "true",
which made it act like we were loading from a non-existing browser window,
thus the JS exception.
(Assignee)

Updated

18 years ago
Whiteboard: [PDT+] → [PDT+]2/24
(Assignee)

Updated

18 years ago
Whiteboard: [PDT+]2/24 → [PDT+]fix in hand 2/24

Comment 10

18 years ago
cc michael lowe, who wrote that dialog
(Assignee)

Comment 11

18 years ago
Created attachment 5723 [details]
Diff for bug fix

Comment 12

18 years ago
i've tested charlie's fix on the mac - works fine.
(Assignee)

Comment 13

18 years ago
Checked in late 2/24
Status: ASSIGNED → RESOLVED
Last Resolved: 18 years ago18 years ago
Resolution: --- → FIXED

Comment 14

18 years ago
verified in 2/25 build.
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.