286841 - Minimonth showMonth is called twice when month changes

Status: RESOLVED FIXED

(Calendar :: Sunbird Only, defect)

Description

[gekacheka]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.5) Gecko/20041107 Firefox/1.0
Build Identifier: 

Minimonth showMonth is called twice whenever displayed month changes.

The methods advanceMonth, switchMonth, and switchYear all set this.value and
call showMonth, but this.value is a property whose onSet handler calls update
which calls showMonth, so those methods should not make a duplicate call to
showMonth.  

Those methods also clear mSelected's selected property, but showMonth also does
that.  

Finally, those methods all call the onmonthchanged handler, but show month could
detect changed months and do that as well, eliminating more duplicated code.

Reproducible: Always

Steps to Reproduce:

Comment 1

[gekacheka]

Attachment: minimonth.xbl month change methods: Remove duplicate calls

(patch -l -p 2 -i file.patch)

Removes redundant calls from advanceMonth, switchMonth, switchYear.
this.mEditorDate is now set ONLY in showMonth.	Always set to 1st of month.
showMonth also handles removing selected property from mSelected.
showMonth also detects month change and calls onmonthchange handler.

Tested on sunbird0.2branch MozCalendar extension on Moz1.8b1.

Comment 2

[gekacheka]

Attachment: minimonth.xml month change methods: Remove duplicate calls (trunk)

(patch -l -p 2 -i file.patch)

Updated patch for trunk.

Note:  only clicking a date changes the value.	Advance month does not change
selected date, so user can look at next month without triggering onchange
listeners, which could change the main calendar grid view.

Comment 3

[Mike Shaver (:shaver emeritus)]

Comment on attachment 182892 [details] [diff] [review]
minimonth.xml month change methods: Remove duplicate calls (trunk)

Marking r+ for woo.

Comment 4

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in