Crash on proxy icon drag if the associated page has a null title.

RESOLVED FIXED in Camino0.9

Status

defect
--
critical
RESOLVED FIXED
14 years ago
14 years ago

People

(Reporter: moz, Assigned: moz)

Tracking

({crash, testcase})

unspecified
Camino0.9
PowerPC
macOS

Details

Attachments

(2 attachments)

(Assignee)

Description

14 years ago
Go to a page with no title tag and attempt to drag the proxy icon on the URL
bar. Chances are, you'll see a crash.

Testcase *and* easy patch forthcoming.
(Assignee)

Comment 1

14 years ago
Posted file Testcase.
(Assignee)

Comment 2

14 years ago
This makes sure |title| is non-nil, and since we've already put the URL data
into the same var, it should use the URL as the title if |title| *is* nil.
(Assignee)

Comment 3

14 years ago
Whoops, changing keywords and assignee (to myself).

(I wonder if this qualifies for the "contributor" list...).
Assignee: pinkerton → mozilla
Keywords: testcase
(Assignee)

Comment 4

14 years ago
Comment on attachment 177973 [details] [diff] [review]
Proposed patch.

I'm gonna check for a reviewer in IRC, but it's so simple a fix it might not
even need more than one look over (if that).
Attachment #177973 - Flags: superreview?(pinkerton)
Attachment #177973 - Flags: review?

Updated

14 years ago
Target Milestone: --- → Camino0.9
Comment on attachment 177973 [details] [diff] [review]
Proposed patch.

sr=pink.
Attachment #177973 - Flags: superreview?(pinkerton) → superreview+

Updated

14 years ago
Severity: major → critical

Updated

14 years ago
Attachment #177973 - Flags: review? → review?(joshmoz)

Updated

14 years ago
Attachment #177973 - Flags: review?(joshmoz) → review+
Checked in.
Status: NEW → RESOLVED
Last Resolved: 14 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.