286878 - In <extensions.js>, "Warning: redeclaration of var pref" and "Warning: redeclaration of var extensionsStrings"

Status: NEW

(Toolkit :: Startup and Profile System, defect)

Description

[Serge Gautherie (:sgautherie)]

[Mozilla Thunderbird, version 1.0+ (20050319)] (nightly) (W98SE)

{{
Warning: redeclaration of var pref
Source File: chrome://mozapps/content/extensions/extensions.js
Line: 146, Column: 8
Source Code:
    var pref = Components.classes["@mozilla.org/preferences-service;1"]

Warning: redeclaration of var extensionsStrings
Source File: chrome://mozapps/content/extensions/extensions.js
Line: 217, Column: 8
Source Code:
    var extensionsStrings = document.getElementById("extensionsStrings");
}}

when starting TB.

Comming from
{{
1.39	ben%bengoodger.com	2004-11-30 14:54	 	Landing the Aviary Branch (Toolkit
sections excluding toolkit/content).
1.19	ben%bengoodger.com	2004-05-10 23:58	 	170006 - better theme manager graphics
}}

Comment 1

[Serge Gautherie (:sgautherie)]

|extensionsStrings| warning comes from
{{
1.30	ben%bengoodger.com	2004-07-13 01:17	 	246050 - text on mouseover tooltips
say extensions in the theme manager... also use consistent uppercase for Themes use
}}

Comment 2

[Serge Gautherie (:sgautherie)]

Attachment: (Av1) <extensions.js>

[Mozilla Thunderbird, version 1.0+ (20050319)] (nightly) (W98SE)

Could you review/check in this patch ? Thanks.

Comment 3

[Serge Gautherie (:sgautherie)]

Attachment: (Av2) <extensions.js> (for review only)

[Mozilla Thunderbird, version 1.0+ (20050319)] (nightly) (W98SE)

Av1, fixed/revised,
plus a 3rd redeclaration fix.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 177990 [details] [diff] [review]
(Av2) <extensions.js> (for review only)

This patch no longer applies.

Comment 5

[Serge Gautherie (:sgautherie)]

Attachment: (Av3-Bw) <extensions.js> (for review only)

Av2-Bw, synchronised with Trunk.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

Comment on attachment 204182 [details] [diff] [review]
(Av3-Bw) <extensions.js> (for review only)

Looking at revision 1.82, I don't see how a strict warning could have been triggered (the variables were in different scopes), but either way, this no longer applies.

Comment 7

[BugBot [:suhaib / :marco/ :calixte]]

The bug assignee didn't login in Bugzilla in the last 7 months.
:mossop, could you have a look please?
For more information, please visit auto_nag documentation.